Daniel Drake wrote:

+       if [[ ! -e "${ROOT}"/usr/share/misc/pci.ids ]]; then
+               myconf="--disable-pci-ids"

- don't use ${ROOT} outside of pkg_*
- en/disabling functionality based on existence of files is kinda
gross, especially when based on what exists on the compiling system,
which could be different than the system the package is ultimately
installed on.  yes it doesn't make much difference right now, but
what happens if hal does start making good use of pci.ids someday?

having pciutils install both a compressed and uncompressed file when
zlib is enabled is a much cleaner solution IMO.

--
                 fonts / wxWindows / gcc-porting / treecleaners
 EFFD 380E 047A 4B51 D2BD  C64F 8AA8 8346 F9A4 0662 (0xF9A40662)

--
[EMAIL PROTECTED] mailing list

Reply via email to