-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mike Frysinger wrote:
> On Tuesday 25 September 2007, Bo �rsted Andresen wrote:
>> On Tuesday 25 September 2007 12:47:35 Marijn Schouten (hkBst) wrote:
>>>>> # "make test" does something weird so default src_test() in
>>>>> /usr/lib/portage/bin/ebuild.sh fails the following test # elif emake
>>>>> -j1 test -n &> /dev/null; then
>>>>> # so copy straight from default src_test() all the stuff which
>>>>> depends on that test passing src_test() {
>>>>> vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
>>>>> if ! emake -j1 test; then
>>>>> hasq test $FEATURES && die "Make test failed. See above for
>>>>> details." hasq test $FEATURES || eerror "Make test failed. See above
>>>>> for details." fi
>>>>> }
>>>> I'm a bit confused about what's going on here. Isn't src_test() only
>>>> supposed to run when 'test' is in FEATURES?
>>> I'm not sure, but as the comment says, I copied this straight from
>>> /usr/lib/portage/bin/ebuild.sh and it goes:
>> [SNIP]
>>
>> Some of that code is unreachable since src_test is never called when test
>> is not in FEATURES. Also there is some dispute as to whether testing the
>> FEATURES variable at all is permitted in ebuilds (bug #174335). In either
>> case it's not needed here. if `emake -j1 test -n` really fails for some
>> reason even though `emake -j1 test` generally works your src_test should
>> just be:
>>
>> src_test() {
>> emake -j1 test || die "Make test failed"
>> }
>
> why is src_test() defined at all ... the default src_test will execute `emake
> check` if possible and then try `emake test`
> -mike
I cannot reproduce the failure that caused me to copy part of the code from
usr/lib/portage/bin/ebuild.sh so I've removed src_test from this bigloo ebuild
and rely now on the default.
Who's gonna fix usr/lib/portage/bin/ebuild.sh?
Marijn
- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFG+nRpp/VmCx0OL2wRAgszAKCibdBHe5WoBZLprKTSxZ02wrKc0wCeNUwq
9snyDtGguXvZoCkF5p1F5tQ=
=yLpT
-----END PGP SIGNATURE-----
--
[EMAIL PROTECTED] mailing list
