On 17:26 Mon 24 Sep , Jurek Bartuszek (jurek) wrote: > jurek 07/09/24 17:26:38 > > Modified: ChangeLog > Added: libgdiplus-1.2.5-r1.ebuild > Log: > dev-dotnet/libgdiplus-1.2.5-r1: Fix linking against image libraries (bug > #192068) > (Portage version: 2.1.3.9)
> cd ${S} > > epatch ${FILESDIR}/${PN}-1.1.13-libungif-configure-fix.diff > epatch ${FILESDIR}/${P}-imglibs.patch Needs quotes for S and FILESDIR. > src_compile() { > if [[ "$(gcc-major-version)" -gt "3" ]] || \ > ( [[ "$(gcc-major-version)" -eq "3" ]] && [[ "$(gcc-minor-version)" > -gt "3" ]] ) Code block { } might be good here instead of a subshell, or perhaps it could use logic that's less convoluted such as if..then. Also don't need the double quotes. > if use ppc ; then > sed -i -e 's:-Werror::g' src/Makefile > fi We should never leave -Werror in -- make this unconditional. It tends to cause large quantities of packages to break every time there's a compiler upgrade. Thanks, Donnie -- [EMAIL PROTECTED] mailing list