Mike Doty wrote:
> Donnie Berkholz wrote:
>> Mike Doty (KingTaco) just told me I could stop sending reviews to -dev
>> that are just about adding quotes or other trivial issues that come up
>> over and over. I'm going to tell you why it's still a good thing.
>>
>> First, where one problem lurks, others often do too. In code with such
>> simple problems, it's likely that more complex problems also exist.
>> Getting more eyes on problematic code of any sort can help find them.
>>
>> Second, as we've already seen, no one developer is familiar with all
>> the code. Both Mike Frysinger and Daniel Drake have responded to some
>> of my reviews, pointing out further problems with the same code.
>>
>> Third, by continuing to post these reviews, it should become obvious
>> to _all_ developers that they should be checking for them _before_
>> committing instead of waiting for a review.
>>
>> Over time, the number of these simple reviews should go dramatically
>> down so it no longer bothers anyone to see them. If it doesn't, that
>> means some of our developers aren't learning or paying attention, and
>> we should take a closer look at whether they should remain developers.
>>
>> Thanks,
>> Donnie
> My concern is that if we flood -dev with "trivial" commit problems then
> more people will stop watching -dev and/or resort to killfiles or other
> filtering. While I do agree with Donnies assessment, my concern is that
> over a longer time period, it might have a negative effect.
I think this is exactly what -dev is for. And the number of trivial
mistakes people are making (not discounting myself) shows this kind of code
review is needed. There is a huge amount of basic stuff, like quoting or
when to use ${ROOT}, that we just don't have documented anywhere, and expect
people to somehow just pick up.
If we flood -dev with "trivial" commit problems then more people will stop
commiting them. If people want to stop reading or filter then that's their
prerogative. -dev isn't a required ML.
--
fonts / wxWindows / gcc-porting / treecleaners
9B81 6C9F E791 83BB 3AB3 5B2D E625 A073 8379 37E8 (0x837937E8)
--
[EMAIL PROTECTED] mailing list
