On Sunday 15 April 2007, Donnie Berkholz wrote:
> Rémi Cardona wrote:
> > Right now, the reworked patch saves a file in
> > /usr/share/gnome2-eclass/${PF}.icons
> >
> > Since committing this will affect everybody including stable users, I
> > would like ebuild/eclass gurus to review this small patch and tell me if
> > there's anything wrong with it.
>
> Why is this going into /usr ? Seems like a temp file to me ... at best,
> /var/cache.ebuilds shouldnt really install anything into /var/cache/ as you should be able to pretty much `rm -rf /var/cache/*` and have things work > Also, is there supposed to be some point where this file > gets deleted, so every subsequent merge doesn't rerun the icon-cache > thing even if it's unnecessary? i guess that's the trick ... if the file is only used to rebuild the icon-cache after merging the package to $ROOT, then i feel like the file should be punted after that (and if anything, src_install would create the list in $D, the pkg_preinst would prep it for use and move it from $D to $T, and the pkg_postinst would utilize the list in $T) ... -mike
signature.asc
Description: This is a digitally signed message part.
