I have a few suggestions for the make_desktop_entry function in eutils.eclass:
1 - Allow me to pass in a full application path. If you pass in the full path to an executable as the first argument, it comes up with a crazy filename like this: /var/tmp/portage/rox-base/mime-editor-0.5/temp//usr/lib/rox/MIME-Editor/AppRun-mime-editor.desktop When a more appropriate name would be: /var/tmp/portage/rox-base/mime-editor-0.5/temp/AppRun-mime-editor.desktop In other words, I propose that this function should probably do 'basename' on $exec before using it for the .desktop filename. 2 - Allow me to explicitly set the name of the .desktop file. This would perhaps solve #1 above as well. I propose an optional environment variable an ebuild can set before calling make_desktop_entry, called "DESKTOP_BASENAME", which would be the basename of the file (not including the .desktop suffix) that the function would use (if set) to create the file. 3 - Allow me to add other important settings like 'NoDisplay', 'OnlyShowIn', and/or 'MimeType'. I propose an optional environment variable 'DESKTOP_EXTRAS' that the ebuild could set before calling make_desktop_entry. This would be an actual verbatim (newline-delimited) copy of the extra lines to be added to the desktop file, for example: DESKTOP_EXTRAS="OnlyShowIn=Yes" or DESKTOP_EXTRAS="MimeType=text/plain NoDisplay=Yes" Any objections? Suggestions? I would be willing to add these myself if no one else is. -- Jim Ramsay Gentoo/Linux Developer (rox)
signature.asc
Description: PGP signature
