Hi Sam,

Slight nit-picking, but while:

commit 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151
Author: Linus Torvalds <torva...@linux-foundation.org>
Date:   2021-09-05 11:24:05 -0700

    Enable '-Werror' by default for all kernel builds

did provide that WERROR=0 option...


... there are still parts in Linux where somehow that makefile option
isn't used, and -Werror is hardcoded, eg:

- tools/bpf/resolve_btfids/Makefile
- tools/build/Build.include
- tools/lib/bpf/Makefile
- tools/objtool/Makefile

So these portions may still break on compiler update (and probably did
in the past, because somehow I have diffs for them in my kernel stash).


... also, maybe for QA reasons it would make sense not to do WERROR=0
when considering stabilization of kernel and/or toolchain?


Best regards,

-- 
Jérôme

On Mon, 2025-04-07 at 21:48 +0100, Sam James wrote:
> WERROR=0 disables -Werror for host tools at least, so let's use that.
> I'll
> also send a config change.
> 
> Bug: https://bugs.gentoo.org/939106
> Bug: https://bugs.gentoo.org/940904
> Bug: https://bugs.gentoo.org/942303
> Signed-off-by: Sam James <s...@gentoo.org>
> ---
> Pushed.
> 
>  eclass/kernel-build.eclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/eclass/kernel-build.eclass b/eclass/kernel-build.eclass
> index 1d8c396b9590b..ee4cf1413a60d 100644
> --- a/eclass/kernel-build.eclass
> +++ b/eclass/kernel-build.eclass
> @@ -207,6 +207,7 @@ kernel-build_src_configure() {
>       tc-export_build_env
>       MAKEARGS=(
>               V=1
> +             WERROR=0
>  
>               HOSTCC="$(tc-getBUILD_CC)"
>               HOSTCXX="$(tc-getBUILD_CXX)"


Reply via email to