+ if tc-is-cross-compiler; then + ZBS_ARGS_BASE+=( + # TODO add to upstream some way to add different search prefixes + # for binaries, include paths and libraries, like existing --prefix-exe-dir etc. + # Right now std.Build.findProgram will try to search here first, before PATH, + # but std.Build.run and std.Build.runAllowFail use passed arguments as is and + # uses std.process.Child under the hood, which itself can use PATH. + #+ # Passing "--search-prefix" when not cross-compiling gives these
Could we move this TODO comment above the function `zig-build_start_base_args`?
1. it will improve readability by giving a TODO block up-front, 2. putting this inside a 3-step indent is a bit too much. -- Have a great day! ~ Maciej Barć https://wiki.gentoo.org/wiki/User:Xgqt 9B0A 4C5D 02A3 B43C 9D6F D6B1 14D7 4A1F 43A6 AC3C
OpenPGP_0x14D74A1F43A6AC3C.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
