commit: 2ebde6581d1aa42be8c21c701217394e1b33c9a5
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Sep 23 01:05:43 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Sep 23 01:06:53 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ebde658
net-analyzer/cloudshark: fix invalid PDEPEND use
pkgcheck now reports:
```
net-analyzer/cloudshark
BadDependency: version 1.0.4: ':=' operator is invalid in:
PDEPEND="net-analyzer/wireshark:=[lua]"
```
This showed up in breaking CI when infra updated pkgcheck.
As for the PDEPEND use here in general, it's invalid both because:
a) PDEPEND should *only* be used for breaking circular dependencies;
b) := is ill-defined in PDEPEND.
This is a plugin for Wireshark hence needs to be in DEPEND+RDEPEND.
Signed-off-by: Sam James <sam <AT> gentoo.org>
.../{cloudshark-1.0.4.ebuild => cloudshark-1.0.4-r1.ebuild} | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net-analyzer/cloudshark/cloudshark-1.0.4.ebuild
b/net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild
similarity index 90%
rename from net-analyzer/cloudshark/cloudshark-1.0.4.ebuild
rename to net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild
index 3904b2a51763..0eee6336f1e0 100644
--- a/net-analyzer/cloudshark/cloudshark-1.0.4.ebuild
+++ b/net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2023 Gentoo Authors
+# Copyright 1999-2024 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -12,8 +12,11 @@ SLOT="0"
KEYWORDS="~amd64 ~arm ~x86"
IUSE=""
-PDEPEND="net-analyzer/wireshark:=[lua]
- net-misc/curl"
+RDEPEND="
+ net-analyzer/wireshark:=[lua]
+ net-misc/curl
+"
+DEPEND="${RDEPEND}"
S="${WORKDIR}/wireshark-plugin-${PV}"
