commit:     0681ed190109e02bb4aaaa748a765682e1fc68d1
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Thu May 23 01:43:14 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu May 23 21:52:04 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0681ed19

net-misc/rsync: remove broken macro and regenerate configure

rsync has a fork of the pre-2016 AC_HEADER_MAJOR with a different fix
from the one autoconf itself implemented. It raises a FP for:

 * QA Notice: Found the following implicit function declarations in configure 
logs:
 *   /var/tmp/portage/net-misc/rsync-3.3.0/work/rsync-3.3.0/config.log:1159 - 
makedev

which is anyways not supposed to be found. We could ignore it, but
better to get rid of the macro itself, considering we anyways often
regenerate autoreconf.

Resulting configure run has no actual differences, just the FP or lack
of FP (and running one fewer compiler probe in src_configure). No
revbump.

Bug: https://github.com/RsyncProject/rsync/issues/616
Closes: https://bugs.gentoo.org/916481
Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 net-misc/rsync/rsync-3.2.7-r4.ebuild | 2 ++
 net-misc/rsync/rsync-3.3.0.ebuild    | 4 +++-
 net-misc/rsync/rsync-9999.ebuild     | 4 +++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/net-misc/rsync/rsync-3.2.7-r4.ebuild 
b/net-misc/rsync/rsync-3.2.7-r4.ebuild
index 9d19a857389f..831a218e466c 100644
--- a/net-misc/rsync/rsync-3.2.7-r4.ebuild
+++ b/net-misc/rsync/rsync-3.2.7-r4.ebuild
@@ -93,6 +93,8 @@ pkg_setup() {
 src_prepare() {
        default
 
+       sed -i -e 's/AC_HEADER_MAJOR_FIXED/AC_HEADER_MAJOR/' configure.ac
+
        if [[ ${PV} == *9999 || -n ${RSYNC_NEEDS_AUTOCONF} ]] ; then
                eaclocal -I m4
                eautoconf -o configure.sh

diff --git a/net-misc/rsync/rsync-3.3.0.ebuild 
b/net-misc/rsync/rsync-3.3.0.ebuild
index c6b7365a04b0..6ea497c2e733 100644
--- a/net-misc/rsync/rsync-3.3.0.ebuild
+++ b/net-misc/rsync/rsync-3.3.0.ebuild
@@ -4,7 +4,7 @@
 EAPI=8
 
 # Uncomment when introducing a patch which touches configure
-#RSYNC_NEEDS_AUTOCONF=1
+RSYNC_NEEDS_AUTOCONF=1
 PYTHON_COMPAT=( python3_{10..12} )
 inherit flag-o-matic prefix python-single-r1 systemd
 
@@ -87,6 +87,8 @@ pkg_setup() {
 src_prepare() {
        default
 
+       sed -i -e 's/AC_HEADER_MAJOR_FIXED/AC_HEADER_MAJOR/' configure.ac
+
        if [[ ${PV} == *9999 || -n ${RSYNC_NEEDS_AUTOCONF} ]] ; then
                eaclocal -I m4
                eautoconf -o configure.sh

diff --git a/net-misc/rsync/rsync-9999.ebuild b/net-misc/rsync/rsync-9999.ebuild
index c6b7365a04b0..6ea497c2e733 100644
--- a/net-misc/rsync/rsync-9999.ebuild
+++ b/net-misc/rsync/rsync-9999.ebuild
@@ -4,7 +4,7 @@
 EAPI=8
 
 # Uncomment when introducing a patch which touches configure
-#RSYNC_NEEDS_AUTOCONF=1
+RSYNC_NEEDS_AUTOCONF=1
 PYTHON_COMPAT=( python3_{10..12} )
 inherit flag-o-matic prefix python-single-r1 systemd
 
@@ -87,6 +87,8 @@ pkg_setup() {
 src_prepare() {
        default
 
+       sed -i -e 's/AC_HEADER_MAJOR_FIXED/AC_HEADER_MAJOR/' configure.ac
+
        if [[ ${PV} == *9999 || -n ${RSYNC_NEEDS_AUTOCONF} ]] ; then
                eaclocal -I m4
                eautoconf -o configure.sh

Reply via email to