commit: 06637c4215d55c57517739214c6e0fd6f8f53914
Author: Michael Orlitzky <mjo <AT> gentoo <DOT> org>
AuthorDate: Sat Apr 19 04:55:56 2014 +0000
Commit: Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
CommitDate: Sat Apr 19 04:55:56 2014 +0000
URL:
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=06637c42
repoman: Add DESCRIPTION.puntuation check (bug #438976)
Basic patch supplied by Michael Orlitzky.
Modified to be easier to add/remove puntuation to the check.
---
bin/repoman | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/bin/repoman b/bin/repoman
index 888892b..17a4ef0 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -318,6 +318,7 @@ qahelp = {
"LICENSE.missing": "Ebuilds that have a missing or empty LICENSE
variable",
"LICENSE.virtual": "Virtuals that have a non-empty LICENSE variable",
"DESCRIPTION.missing": "Ebuilds that have a missing or empty
DESCRIPTION variable",
+ "DESCRIPTION.punctuation": "DESCRIPTION ends with a period character",
"DESCRIPTION.toolong": "DESCRIPTION is over %d characters" %
max_desc_len,
"EAPI.definition": "EAPI definition does not conform to PMS section
7.3.1 (first non-comment, non-blank line)",
"EAPI.deprecated": "Ebuilds that use features that are deprecated in
the current EAPI",
@@ -385,6 +386,7 @@ qawarnings = set((
"dependency.badindev",
"dependency.badmaskedindev",
"dependency.badtilde",
+"DESCRIPTION.punctuation",
"DESCRIPTION.toolong",
"EAPI.deprecated",
"HOMEPAGE.virtual",
@@ -1890,6 +1892,12 @@ for x in effective_scanlist:
stats[myqakey] += 1
fails[myqakey].append(relative_path)
+ if myaux['DESCRIPTION'][-1:] in ['.']:
+ stats['DESCRIPTION.punctuation'] += 1
+ fails['DESCRIPTION.punctuation'].append(
+ "%s: DESCRIPTION ends with a '%s' character"
+ % (relative_path, myaux['DESCRIPTION'][-1:])
+
# 14 is the length of DESCRIPTION=""
if len(myaux['DESCRIPTION']) > max_desc_len:
stats['DESCRIPTION.toolong'] += 1
