commit: db67b757bba1fe1263d5b6c2ca5cd987b6b1e61a
Author: Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Thu Jun 26 14:42:40 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Jun 28 02:30:19 2025 +0000
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=db67b757
10executable-issues: use the += operator to append to variables
As an extension to the Shell Command Language, bash supports the +=
operator, which allows for the values of variables to be appended to.
There are three instances in which the "10executable-issues" unit can
benefit from this operator. Have it do so.
Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>
bin/install-qa-check.d/10executable-issues | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bin/install-qa-check.d/10executable-issues
b/bin/install-qa-check.d/10executable-issues
index 164f062a21..1311486f2c 100644
--- a/bin/install-qa-check.d/10executable-issues
+++ b/bin/install-qa-check.d/10executable-issues
@@ -67,7 +67,7 @@ elf_check() {
local qa_var="QA_TEXTRELS_${ARCH/-/_}"
[[ -n ${!qa_var} ]] && QA_TEXTRELS=${!qa_var}
[[ -n ${QA_STRICT_TEXTRELS} ]] && QA_TEXTRELS=""
- export QA_TEXTRELS="${QA_TEXTRELS} lib*/modules/*.ko"
+ export QA_TEXTRELS+=" lib*/modules/*.ko"
f=$(scanelf -qyRF '%t %p' "${ED%/}/" | grep -v 'usr/lib/debug/')
if [[ -n ${f} ]] ; then
scanelf -qyRAF '%T %p' "${PORTAGE_BUILDDIR}"/ &>
"${T}"/scanelf-textrel.log
@@ -109,8 +109,8 @@ elf_check() {
qa_var="QA_WX_LOAD_${ARCH/-/_}"
[[ -n ${!qa_var} ]] && QA_WX_LOAD=${!qa_var}
[[ -n ${QA_STRICT_WX_LOAD} ]] && QA_WX_LOAD=""
- export QA_EXECSTACK="${QA_EXECSTACK}
lib*/modules/*.ko"
- export QA_WX_LOAD="${QA_WX_LOAD}
lib*/modules/*.ko"
+ export QA_EXECSTACK+=" lib*/modules/*.ko"
+ export QA_WX_LOAD+=" lib*/modules/*.ko"
f=$(scanelf -qyRAF '%e %p' "${ED%/}/" | grep -v
'usr/lib/debug/')
;;
esac
