commit:     1c3522c4bd293fb6aaca25f95d12ea09a2563ee2
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Mon Jun  9 20:17:25 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Jun 11 03:26:19 2025 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=1c3522c4

estrip: mute an instance of SC2094 that is a false-positive

Shellcheck sees that process_elf() is given the value of 'inode_link' as
an argument within a loop reading from a file whose name is the same
value, duly reporting it as a potential issue. It is not, however.

Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 bin/estrip | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/bin/estrip b/bin/estrip
index 01bbd81d4a..65932e9886 100755
--- a/bin/estrip
+++ b/bin/estrip
@@ -584,9 +584,8 @@ fi
 # Now we look for unstripped binaries.
 for inode_link in *; do
        test -e "${inode_link}" || continue
-       while read -r x
-       do
-
+       # shellcheck disable=2094
+       while read -r x; do
                if (( do_banner )); then
                        __vecho "strip: ${name_of[strip]} 
${portage_strip_flags[*]}"
                        do_banner=0

Reply via email to