commit: e44c31cffbedc5a53c6b408515f25f8d808e00b1
Author: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
AuthorDate: Mon Jun 2 13:24:22 2025 +0000
Commit: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
CommitDate: Mon Jun 2 13:24:22 2025 +0000
URL:
https://gitweb.gentoo.org/proj/pkgcore/pkgcheck.git/commit/?id=e44c31cf
BannedEapiCommand: add test for EAPI=9 banned commands
Signed-off-by: Arthur Zamarin <arthurzam <AT> gentoo.org>
.../BadCommandsCheck/BannedEapiCommand/expected.json | 2 ++
.../BadCommandsCheck/BannedEapiCommand/fix.patch | 14 ++++++++++++++
.../BannedEapiCommand/BannedEapiCommand-3.ebuild | 15 +++++++++++++++
3 files changed, 31 insertions(+)
diff --git
a/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/expected.json
b/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/expected.json
index d441021b..36b765e4 100644
---
a/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/expected.json
+++
b/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/expected.json
@@ -3,3 +3,5 @@
{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package":
"BannedEapiCommand", "version": "1", "line": "best_version --host-root
stub/stub1:2", "lineno": 12, "command": "best_version --host-root", "eapi": "7"}
{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package":
"BannedEapiCommand", "version": "2", "line": "usermod -s /bin/bash uucp",
"lineno": 9, "command": "usermod", "eapi": "6"}
{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package":
"BannedEapiCommand", "version": "2", "line": "usermod -s /bin/false uucp",
"lineno": 13, "command": "usermod", "eapi": "6"}
+{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package":
"BannedEapiCommand", "version": "3", "line": "assert \"failed\"", "lineno": 10,
"command": "assert", "eapi": "9"}
+{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package":
"BannedEapiCommand", "version": "3", "line": "domo foo.po", "lineno": 14,
"command": "domo", "eapi": "9"}
diff --git
a/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/fix.patch
b/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/fix.patch
index a0950afe..bfe6f82f 100644
---
a/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/fix.patch
+++
b/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/fix.patch
@@ -39,3 +39,17 @@ diff -Naur
standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebu
-pkg_postrm() {
- usermod -s /bin/false uucp || die
-}
+diff -Naur
standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
fixed/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
+--- standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
++++ fixed/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
+@@ -7,9 +7,5 @@ SLOT="0"
+
+ src_unpack() {
+ tar -xzf foo.tar.gz 3 | hexdump -C
+- assert "failed"
+-}
+-
+-src_install() {
+- domo foo.po
++ pipestatus || die "failed"
+ }
diff --git
a/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
b/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
new file mode 100644
index 00000000..fb28bd7d
--- /dev/null
+++
b/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-3.ebuild
@@ -0,0 +1,15 @@
+EAPI=9
+
+DESCRIPTION="Ebuild using banned commands"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck";
+LICENSE="BSD"
+SLOT="0"
+
+src_unpack() {
+ tar -xzf foo.tar.gz 3 | hexdump -C
+ assert "failed"
+}
+
+src_install() {
+ domo foo.po
+}
