commit:     8ca4a7022adc1c7fa24a1da1cfda9aad39d993de
Author:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Tue May 13 06:06:19 2025 +0000
Commit:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
CommitDate: Tue May 13 15:18:58 2025 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=8ca4a702

fix missing shlex import in error path

Regression in commit 002cd09b455eae1790f113438a030828edf3ef14. Since the
function we need isn't invisibly exposed via portage.*, we need to
distinctly import it. We did in most cases, but not here.

Caught by flake8's missing imports linter. Unfortunately, the overall
usefulness of flake8 here is effectively nil, because lazyimport means
*all* imports are "missing". It is too noisy to believe. But I actually
spotted this error, it's not a false positive, and we might as well fix
it immediately.

Fixes: 002cd09b455eae1790f113438a030828edf3ef14
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>
Closes: https://github.com/gentoo/portage/pull/1438
Signed-off-by: Mike Gilbert <floppym <AT> gentoo.org>

 bin/install.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/install.py b/bin/install.py
index dcf9ca5287..b21249e5e8 100755
--- a/bin/install.py
+++ b/bin/install.py
@@ -4,6 +4,7 @@
 
 import argparse
 import os
+import shlex
 import stat
 import sys
 import subprocess

Reply via email to