commit: 82d1929a4c37d7ba10c121ce9d19759d6a436834 Author: Eli Schwartz <eschwartz <AT> gentoo <DOT> org> AuthorDate: Thu Jan 16 05:47:05 2025 +0000 Commit: Eli Schwartz <eschwartz <AT> gentoo <DOT> org> CommitDate: Wed Apr 23 18:11:08 2025 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82d1929a
net-misc/rsync: drop useless dependency on sys-apps/attr When USE=xattr is enabled, the configure script checks for -lattr and attempts to link to it for good luck. It also checks for attr/xattr.h, but only includes it in an if/elif when sys/xattr.h doesn't exist -- this makes sense, since the former simply #includes the latter and then emits a #warning telling you to migrate to libc. Presumably, this is meant as a sort of infinite compatibility thing and "it's fine if you use --as-needed" in practice. rsync doesn't actually include any of libattr's non-deprecated headers, just xattr.h and at runtime libattr.so is not needed despite automagically detecting it during configure. Upstream fix for false detection: https://github.com/RsyncProject/rsync/pull/753 Fixes: ``` * VDB: detected possibly incorrect RDEPEND (net-misc/rsync-3.3.0-r2) * sys-apps/attr < ``` No revbump, this package won't be depcleaned anyway so forcing a rebuild feels pointless. Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org> net-misc/rsync/rsync-3.3.0-r2.ebuild | 3 ++- net-misc/rsync/rsync-3.4.1.ebuild | 3 ++- net-misc/rsync/rsync-9999.ebuild | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/net-misc/rsync/rsync-3.3.0-r2.ebuild b/net-misc/rsync/rsync-3.3.0-r2.ebuild index 7fbdb2af33fe..15d984eea4a6 100644 --- a/net-misc/rsync/rsync-3.3.0-r2.ebuild +++ b/net-misc/rsync/rsync-3.3.0-r2.ebuild @@ -41,6 +41,8 @@ IUSE="acl examples iconv lz4 rrsync ssl stunnel system-zlib xattr xxhash zstd" REQUIRED_USE+=" examples? ( ${PYTHON_REQUIRED_USE} )" REQUIRED_USE+=" rrsync? ( ${PYTHON_REQUIRED_USE} )" +# attr is autodetected and then dropped by -Wl,--as-needed: +# https://github.com/RsyncProject/rsync/pull/753 RDEPEND=" >=dev-libs/popt-1.5 acl? ( virtual/acl ) @@ -57,7 +59,6 @@ RDEPEND=" ) ssl? ( dev-libs/openssl:= ) system-zlib? ( sys-libs/zlib ) - xattr? ( kernel_linux? ( sys-apps/attr ) ) xxhash? ( >=dev-libs/xxhash-0.8 ) zstd? ( >=app-arch/zstd-1.4:= ) iconv? ( virtual/libiconv )" diff --git a/net-misc/rsync/rsync-3.4.1.ebuild b/net-misc/rsync/rsync-3.4.1.ebuild index 759c2d0bd78d..0267e4ccbf0c 100644 --- a/net-misc/rsync/rsync-3.4.1.ebuild +++ b/net-misc/rsync/rsync-3.4.1.ebuild @@ -41,6 +41,8 @@ IUSE="acl examples iconv lz4 rrsync ssl stunnel system-zlib xattr xxhash zstd" REQUIRED_USE+=" examples? ( ${PYTHON_REQUIRED_USE} )" REQUIRED_USE+=" rrsync? ( ${PYTHON_REQUIRED_USE} )" +# attr is autodetected and then dropped by -Wl,--as-needed: +# https://github.com/RsyncProject/rsync/pull/753 RDEPEND=" >=dev-libs/popt-1.19 acl? ( virtual/acl ) @@ -57,7 +59,6 @@ RDEPEND=" ) ssl? ( dev-libs/openssl:= ) system-zlib? ( sys-libs/zlib ) - xattr? ( kernel_linux? ( sys-apps/attr ) ) xxhash? ( >=dev-libs/xxhash-0.8 ) zstd? ( >=app-arch/zstd-1.4:= ) iconv? ( virtual/libiconv )" diff --git a/net-misc/rsync/rsync-9999.ebuild b/net-misc/rsync/rsync-9999.ebuild index 759c2d0bd78d..0267e4ccbf0c 100644 --- a/net-misc/rsync/rsync-9999.ebuild +++ b/net-misc/rsync/rsync-9999.ebuild @@ -41,6 +41,8 @@ IUSE="acl examples iconv lz4 rrsync ssl stunnel system-zlib xattr xxhash zstd" REQUIRED_USE+=" examples? ( ${PYTHON_REQUIRED_USE} )" REQUIRED_USE+=" rrsync? ( ${PYTHON_REQUIRED_USE} )" +# attr is autodetected and then dropped by -Wl,--as-needed: +# https://github.com/RsyncProject/rsync/pull/753 RDEPEND=" >=dev-libs/popt-1.19 acl? ( virtual/acl ) @@ -57,7 +59,6 @@ RDEPEND=" ) ssl? ( dev-libs/openssl:= ) system-zlib? ( sys-libs/zlib ) - xattr? ( kernel_linux? ( sys-apps/attr ) ) xxhash? ( >=dev-libs/xxhash-0.8 ) zstd? ( >=app-arch/zstd-1.4:= ) iconv? ( virtual/libiconv )"
