[gentoo-commits] proj/pkgcore/pkgcheck:master commit in: src/pkgcheck/checks/

[Arthur Zamarin]

commit:     f444cf692ecbd913d1c226438a200ff5e9f8a999
Author:     Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
AuthorDate: Thu Feb 27 19:27:33 2025 +0000
Commit:     Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
CommitDate: Thu Feb 27 19:27:33 2025 +0000
URL:        
https://gitweb.gentoo.org/proj/pkgcore/pkgcheck.git/commit/?id=f444cf69

TooManyCrates: new check for >300 CRATES

Signed-off-by: Arthur Zamarin <arthurzam <AT> gentoo.org>

 src/pkgcheck/checks/rust.py | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/src/pkgcheck/checks/rust.py b/src/pkgcheck/checks/rust.py
index 7a5cbdad..346ba412 100644
--- a/src/pkgcheck/checks/rust.py
+++ b/src/pkgcheck/checks/rust.py
@@ -31,6 +31,24 @@ class SuboptimalCratesURICall(results.LineResult, 
results.Warning):
         return f"line: {self.lineno}: calling {self.line!r} is suboptimal, use 
'${{CARGO_CRATE_URIS}}' for global CRATES instead"
 
 
+class TooManyCrates(results.VersionResult, results.Warning):
+    """Too many crates in ``CRATES`` variable.
+
+    The ``CRATES`` variable is a space-separated list of crates. When it has
+    more than 300 crates, it can cause performance issues for metadata
+    generation and package manager handling. It is recommended to use a crates
+    tarball instead.
+    """
+
+    def __init__(self, count: int, **kwargs):
+        super().__init__(**kwargs)
+        self.count = count
+
+    @property
+    def desc(self):
+        return f"CRATES variable has {self.count} crates, consider using 
crates tarball instead"
+
+
 class RustCheck(Check):
     """Checks for rust related issues."""
 
@@ -39,6 +57,7 @@ class RustCheck(Check):
         {
             SuboptimalCratesSeparator,
             SuboptimalCratesURICall,
+            TooManyCrates,
         }
     )
 
@@ -49,7 +68,10 @@ class RustCheck(Check):
                 val_node = node.children[-1]
                 row, _ = val_node.start_point
                 val_str = pkg.node_str(val_node).strip("'\"")
-                for lineno, line in enumerate(val_str.splitlines(), start=row 
+ 1):
+                crates = val_str.split()
+                if len(crates) > 300:
+                    yield TooManyCrates(count=len(crates), pkg=pkg)
+                for lineno, line in enumerate(crates, start=row + 1):
                     for token in line.split():
                         if "@" not in token:
                             yield SuboptimalCratesSeparator(