commit:     1ee844b8af0f2e8c1b2cfbb15b1f102a09740602
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Feb  4 17:52:58 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Feb  4 17:55:33 2025 +0000
URL:        https://gitweb.gentoo.org/proj/kde.git/commit/?id=1ee844b8

kde-apps/kwave: drop "optimised" memcpy

kwave currently ships with optimised/accelerated implementations of memcpy for
various architectures, sourced from xine. This shouldn't be needed these days,
as glibc at least has various SIMD memcpy implementations, but also, compilers
are very good at both pattern recognition and vectorisation these days.

If we were to keep this, we would likely want to make it gated on USE=asm
anyway (though I think there's some other, non-memcpy AVX inline asm used
which I haven't looked at).

Bug: https://bugs.kde.org/show_bug.cgi?id=499512
Signed-off-by: Sam James <sam <AT> gentoo.org>

 kde-apps/kwave/kwave-24.12.49.9999.ebuild | 2 ++
 kde-apps/kwave/kwave-9999.ebuild          | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/kde-apps/kwave/kwave-24.12.49.9999.ebuild 
b/kde-apps/kwave/kwave-24.12.49.9999.ebuild
index 237d892916..33717164bb 100644
--- a/kde-apps/kwave/kwave-24.12.49.9999.ebuild
+++ b/kde-apps/kwave/kwave-24.12.49.9999.ebuild
@@ -79,6 +79,8 @@ src_configure() {
                -DWITH_OGG_VORBIS=$(usex vorbis)
                -DWITH_OGG_OPUS=$(usex opus)
                -DWITH_OSS=$(usex oss)
+               # https://bugs.kde.org/show_bug.cgi?id=499512
+               -DWITH_OPTIMIZED_MEMCPY=OFF
                -DWITH_PULSEAUDIO=$(usex pulseaudio)
                -DWITH_QT_AUDIO=$(usex qtmedia)
        )

diff --git a/kde-apps/kwave/kwave-9999.ebuild b/kde-apps/kwave/kwave-9999.ebuild
index 8a2d6467b8..0679955b9b 100644
--- a/kde-apps/kwave/kwave-9999.ebuild
+++ b/kde-apps/kwave/kwave-9999.ebuild
@@ -79,6 +79,8 @@ src_configure() {
                -DWITH_OGG_VORBIS=$(usex vorbis)
                -DWITH_OGG_OPUS=$(usex opus)
                -DWITH_OSS=$(usex oss)
+               # https://bugs.kde.org/show_bug.cgi?id=499512
+               -DWITH_OPTIMIZED_MEMCPY=OFF
                -DWITH_PULSEAUDIO=$(usex pulseaudio)
                -DWITH_QT_AUDIO=$(usex qtmedia)
        )

Reply via email to