commit:     7d93b5eb9ae81c5b25e0c605629d17aff08b87bc
Author:     Oliver Freyermuth <o.freyermuth <AT> googlemail <DOT> com>
AuthorDate: Sat Mar 22 22:40:10 2014 +0000
Commit:     Christoph Junghans <ottxor <AT> gentoo <DOT> org>
CommitDate: Sat Mar 22 22:40:10 2014 +0000
URL:        
http://git.overlays.gentoo.org/gitweb/?p=proj/sci.git;a=commit;h=7d93b5eb

Fix indentation issues, missing and superfluous die, 80 chars. Repoman seems 
fine now.

---
 sci-physics/genfit/ChangeLog              |  4 ++++
 sci-physics/genfit/genfit-02.00.00.ebuild | 16 ++++++----------
 sci-physics/genfit/metadata.xml           | 27 +++++++++++++++++++--------
 3 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/sci-physics/genfit/ChangeLog b/sci-physics/genfit/ChangeLog
index bf38d56..c31bd35 100644
--- a/sci-physics/genfit/ChangeLog
+++ b/sci-physics/genfit/ChangeLog
@@ -2,6 +2,10 @@
 # Copyright 1999-2014 Gentoo Foundation; Distributed under the GPL v2
 # $Header: $
 
+  22 Mar 2014; <o.freyerm...@googlemail.com> genfit-02.00.00.ebuild, 
metadata.xml:
+  Address ebuild issues found in review (indentation, missing and superfluous
+  die's). 
+
 *genfit-02.00.00 (22 Mar 2014)
 
   22 Mar 2014; <o.freyerm...@googlemail.com> +genfit-02.00.00.ebuild, 
+metadata.xml:

diff --git a/sci-physics/genfit/genfit-02.00.00.ebuild 
b/sci-physics/genfit/genfit-02.00.00.ebuild
index 1955aa9..f86c7b3 100644
--- a/sci-physics/genfit/genfit-02.00.00.ebuild
+++ b/sci-physics/genfit/genfit-02.00.00.ebuild
@@ -26,12 +26,8 @@ DEPEND="${RDEPEND}
 
 src_compile() {
        cmake-utils_src_compile
-       if use doc; then
-               cmake-utils_src_compile doc || die
-       fi
-       if use examples; then
-               cmake-utils_src_compile tests || die
-       fi
+       use doc      && cmake-utils_src_compile doc
+       use examples && cmake-utils_src_compile tests
 }
 
 src_install() {
@@ -42,13 +38,13 @@ src_install() {
                doins "${S}/test/makeGeom.C"
                doins "${S}/test/README"
        fi
-       cd doc
+       cd doc || die
        use doc && dohtml -r "${S}/doc/html/"*
-        echo
-        elog "Note that there is no support in this ebuild for RAVE yet,"
+       echo
+       elog "Note that there is no support in this ebuild for RAVE yet,"
        elog "which is also not in portage."
        elog "It should be possible to use a local installation of RAVE"
        elog "and set:"
        elog "  export RAVEPATH=<yourRaveDirectory>"
-        echo
+       echo
 }

diff --git a/sci-physics/genfit/metadata.xml b/sci-physics/genfit/metadata.xml
index e2510af..b767bdd 100644
--- a/sci-physics/genfit/metadata.xml
+++ b/sci-physics/genfit/metadata.xml
@@ -3,18 +3,29 @@
 <pkgmetadata>
   <herd>sci-physics</herd>
   <longdescription lang="en">
-GENFIT is an experiment-independent framework for track reconstruction for 
particle and nuclear physics. It consists of three modular components:
+GENFIT is an experiment-independent framework for track reconstruction for
+particle and nuclear physics. It consists of three modular components:
 - Track fitting algorithms
-  Currently, GENFIT contains a Kalman Filter and a Deterministic Annealing 
Filter. 
+  Currently, GENFIT contains a Kalman Filter and a
+  Deterministic Annealing Filter. 
   Other algorithm modules can be added easily.
 - Track representations
-  These modules hold the data of track track parameters and can perform 
extrapolations of these parameters. 
+  These modules hold the data of track track parameters and can perform
+  extrapolations of these parameters. 
   GENFIT is distributed with two well-tested track representations.
-  Existing track extrapolation codes can be interfaced in a very 
straightforward way in this framework, using their native geometry and magnetic 
field interfaces.
+  Existing track extrapolation codes can be interfaced in a very
+  straightforward way in this framework, using their native geometry
+  and magnetic field interfaces.
 - Reconstruction hits
-  The hit dimensionality and the orientation of planar tracking detectors can 
be chosen freely. 
-  GENFIT is especially useful for tracking systems which include detectors 
which do not measure the passage of particles on predefined planes, like TPCs 
or wire-based drift chambers. The concept of so-called virtual detector planes 
provides a simple mechanism to use these detector hits in a transparent way 
without any geometrical simplifications.
-GENFIT has been developed in the framework of the PANDA experiment at FAIR, 
Darmstadt, Germany. 
-It is also used in the Belle-2, Fopi, and GEM-TPC experiments.
+  The hit dimensionality and the orientation of planar tracking detectors
+  can be chosen freely. 
+GENFIT is especially useful for tracking systems which include detectors
+which do not measure the passage of particles on predefined planes,
+like TPCs or wire-based drift chambers. The concept of so-called
+virtual detector planes provides a simple mechanism to use these
+detector hits in a transparent way without any geometrical simplifications.
+GENFIT has been developed in the framework of the PANDA experiment at
+FAIR, Darmstadt, Germany. 
+It is also used in the Belle-2, Fopi, and GEM-TPC experiments. 
   </longdescription>
 </pkgmetadata>

Reply via email to