Thanks JB, here is the PR -> https://github.com/apache/incubator-toree/pull/252
On Fri, Mar 20, 2026 at 7:37 AM Jean-Baptiste Onofré <[email protected]> wrote: > Thanks a lot Luciano ! Much appreciated ! > > Please let me know if you need my help (PRs or reviews), as usual, I'm > happy to help :) > > Regards > JB > > On Fri, Mar 20, 2026 at 2:32 PM Luciano Resende <[email protected]> > wrote: > > > On Fri, Mar 20, 2026 at 1:43 AM Jean-Baptiste Onofré <[email protected]> > > wrote: > > > > > -1 (binding) > > > > > > The LICENSE/NOTICE in the binary distribution is not fully correct (see > > > below). > > > It should be fixed. > > > > > > I checked: > > > - source distribution > > > -- incubating is in the name/version > > > -- signature and checksum are good > > > -- DISCLAIMER is present > > > -- LICENSE and NOTICE are good > > > -- ASF header is present in all expected files > > > -- No binary/compiled file in the source distribution > > > - bin distribution > > > -- incubating is in the name/version > > > -- signature and checksum are good > > > -- DISCLAIMER is present > > > -- LICENSE is not fully correct: > > > --- jackson-datatype-jsr310 is present in the distribution but not > > > documented in the LICENSE file > > > --- spring-jcl is present in the distribution but not documented in the > > > LICENSE file > > > --- coursier-util is present in the distribution but not documented in > > the > > > LICENSE file > > > --- the LICENSE documents slf4j-api 1.7.32 but the distribution > includes > > > slf4j-api 2.0.16 > > > -- NOTICE is not fully correct: it documents scala-xml 2.1.0 but the > > > LICENSE documents scala-xml 1.3.0 (it should be aligned) > > > > > > Thanks ! > > > Regards > > > JB > > > > > > > > Good catch, JB. It’s interesting to see how we can still miss some of > these > > details.... > > Let me cancel this vote. We are already reviewing a fix for these and a > few > > other similar issues in the project development list. > > > > Cheers, > > > > -- > > Luciano Resende > > http://twitter.com/lresende1975 > > http://lresende.blogspot.com/ > > > -- Luciano Resende http://twitter.com/lresende1975 http://lresende.blogspot.com/
