Thanks for the feedback, PJ! I will address it in the upcoming release candidate.
Regarding, "The file name 'otava-0.6.0+incubating.tar.gz' is confusing.". This is one of two artifacts produced by the Python build system. The same artifact names are used by other Python ASF projects. For example, I used the same structure as airflow [1]. A slightly different structure is maintained by datasketches [2]. They keep the source archive in the root of the release directory and artifacts required for PyPi in the "PyPi" directory. I agree that it is slightly confusing that there are 2 .tar.gz files. Would it help if I switch to the structure used by datasketches? [1] https://dlcdn.apache.org/airflow/3.0.0/ [2] https://dlcdn.apache.org/datasketches/python/5.2.0/ Best, Alex On Thu, May 8, 2025 at 2:32 AM PJ Fanning <fannin...@apache.org> wrote: > -1 binding > > * The NOTICE file does not include '(Incubating)' after the podling name. > https://github.com/apache/amoro/blob/master/NOTICE is a valid example > * No DISCLAIMER in otava-0.6.0+incubating.tar.gz or in > otava-0.6.0+incubating-py3-none-any.whl > * The email address in otava-0.6.0+incubating.dist-info/METADATA (in > the wheel file) has an individual's non Apache email address > I think this should have an address like d...@otava.apache.org. It is > not the ASF norm for individual's to take the credit for maintaining > files - it is a team effort. > > > I would prefer if the LICENSE, NOTICE and DISCLAIMER had no `.txt` > suffix. This is not the norm but probably allowable. > > If you want Incubator members to run your build and you have it listed > in your checklist, you should provide a detailed description about how > to do this build, maybe as a link to a page on your web site (or in > GitHub). > > Could the KEYS use your apache.org email addresses and not the gmail > ones? Multiple email addresses are allowed but 1 should be your > apache.org email. > > > On Thu, 8 May 2025 at 09:56, PJ Fanning <fannin...@apache.org> wrote: > > > > The KEYS file link should be > > > > https://downloads.apache.org/incubator/otava/KEYS > > which is a symlink for > > https://dist.apache.org/repos/dist/release/incubator/otava/KEYS > > > > You should not maintain a dev KEYS file, that is this file should be > deleted > > https://dist.apache.org/repos/dist/dev/incubator/otava/KEYS > > > > Or at least it should be a symlink for the > dist/release/incubator/otava/KEYS file. > > > > You are missing the header that we include in the KEYS file describing > how to import it. > > > > Have a look at the Teaclave file for an example. > > https://downloads.apache.org/incubator/teaclave/KEYS > > > > On 2025/05/08 08:48:18 PJ Fanning wrote: > > > The file names in the release normally contain 'apache', eg > 'apache-otava-...'. > > > The file name 'otava-0.6.0+incubating.tar.gz' is confusing. Could you > add a suffix to the name describing what this is? > > > > > > These are not blockers for this release but just requests for the next > RC. > > > > > > > > > On 2025/05/05 20:50:58 Henrik Ingo wrote: > > > > On Mon, May 5, 2025 at 8:09 AM Alexander Sorokoumov < > > > > aleksandr.sorokou...@gmail.com> wrote: > > > > > > > > > Hello, > > > > > > > > > > This is a call for a vote to release Apache Otava > 0.6.0+incubating-RC3. > > > > > > > > > > The vote thread: > > > > > https://lists.apache.org/thread/9llkboq8h8qg334yb4m5rgtz17zfpl0f > > > > > Vote result: > > > > > https://lists.apache.org/thread/r6j7nr3ydo6ggpv9fkdfg6xl8btg38yj > > > > > Release candidate: > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/otava/0.6.0+incubating-RC3/ > > > > > Git tag for the release: > > > > > > https://github.com/apache/otava/releases/tag/0.6.0%2Bincubating-RC3 > > > > > > > > > > The artifacts have been signed with Key [ > E81152E1F17593C0949A9D235E > > > > > 2C934B6C5147A0 ], corresponding to aleksandr.sorokou...@gmail.com > > > > > available > > > > > here https://dist.apache.org/repos/dist/dev/incubator/otava/KEYS. > > > > > > > > > > This vote will be open for at least 72 hours. > > > > > > > > > > Checklist for reference: > > > > > > > > > > [ ] Download links are valid. > > > > > [ ] Checksums and signatures. > > > > > [ ] LICENSE/NOTICE files exist > > > > > [ ] No unexpected binary files > > > > > [ ] All source files have ASF headers > > > > > [ ] Can install from source > > > > > [ ] Can run examples using all supported Python versions > > > > > > > > > > To learn more about Apache Otava, please see > https://otava.apache.org. > > > > > > > > > > > > > > Thanks Alex > > > > > > > > As a committer on the podling, who already verified all of the above > to > > > > vote on the podling vote thread, I assume I can simply: > > > > > > > > +1 (non-binding) > > > > > > > > ...here? > > > > > > > > henrik > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
