Are we talking about RC1 or RC5 ?

I'm confused.

On Fri, Mar 7, 2025 at 5:17 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote:
>
> +1 (binding)
>
> I checked:
> - incubating is in the name/version
> - hash and checksum are good
> - DISCLAIMER is there and good
> - LICENSE and NOTICE are good
> - no binary file found in the source distribution
> - some files don't contain ASF header:
>     - CONTRIBUTING.md
>     - README.md
>     - pkg/datasource/sql/mock/README.md
>     - pkg/datasource/sql/undo/parser/branch_undo_log.pb.go (it seems
> to have been generated by protoc-gen-go, but the ASF header should be
> added anyway as part of the source distribution)
>     - pkg/discovery/mock/mock_etcd_client.go (it seems generated by
> MockGen, but the ASF header should be added anyway as part of the
> source distribution)
>
> If you can fix the ASF header in the next release, that would be great.
>
> Thanks
> Regards
> JB
>
> On Thu, Mar 6, 2025 at 5:05 PM luky...@apache.org <luky...@apache.org> wrote:
> >
> > Hello,
> >
> > This is the first release of Apache Seata-go(incubating) SDK.
> >
> >
> > The vote thread:
> > https://lists.apache.org/thread/6yym26plkrf4ld6s0bf9zts5wwwg0gtq
> >
> >
> > Vote Result:
> > https://lists.apache.org/thread/ko9hf9t9wp14wzgoxcks5cyglg68jrpb
> >
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata-go/2.0.0-RC1/
> >
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-seata-go/tree/v2.0.0
> >
> >
> > Git commit id for the release:
> > https://github.com/apache/incubator-seata-go/commit/cf2212a41550649b5b32dc029a608d3746f5de3a
> >
> >
> > Release Notes:
> > https://github.com/apache/incubator-seata-go/releases/tag/v2.0.0
> >
> >
> > The artifacts have been signed with Key [ A2EF5873 ], corresponding to
> > [ luky...@apache.org ]
> > which can be found in the keys file:
> > https://downloads.apache.org/incubator/seata/KEYS
> >
> >
> > Build Environment: Golang 1.20+.
> > Build Command: make build.
> >
> >
> > CI Test Workflow:
> > https://github.com/apache/incubator-seata-go/actions/runs/12517972078/job/34919641932
> > https://github.com/apache/incubator-seata-go/actions/runs/12517972075/job/34919641931
> >
> >
> > The vote will be open for at least 72 hours.
> >
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> >
> > Checklist for reference:
> > [ ] Download links are valid.
> > [ ] Checksums and signatures.
> > [ ] LICENSE/NOTICE files exist
> > [ ] No unexpected binary files
> > [ ] All source files have ASF headers
> > [ ] Can compile from source
> >
> >
> > To learn more about Apache Seata , please see https://seata.apache.org/
> > Warm regards,
> > Yuecai Liu
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
> > [VOTE] Release Apache Seata (Incubating) 2.1.0-RC5

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to