Oh I guess you mean that it should be DISCLAIMER not DISCLAIMER-WIP (as one code copy as been removed before the release, we are fully following ASF policy now).
It was not clear for me in your vote message but it makes sense. I will fix that quickly and submit a new release here. Regards JB Le jeu. 13 févr. 2025 à 04:12, Jean-Baptiste Onofré <j...@nanthrax.net> a écrit : > Hi Justin > > Thanks for your review. > > Can you point what's wrong with the DISCLAIMER_WIP ? > > In Polaris, the DISCLAIMER_WIP says: > > "Apache Polaris is an effort undergoing incubation at The Apache > Software Foundation (ASF), sponsored by the Apache Incubator. > Incubation is required of all newly accepted projects until a further > review indicates that the infrastructure, communications, and > decision-making process have stabilized in a manner consistent with > other successful ASF projects. While incubation status is not > necessarily a reflection of the completeness or stability of the code, > it does indicate that the project has yet to be fully endorsed by the > ASF. > > If you are planning to incorporate this work into your > product/project, please be aware that you will need to conduct a > thorough licensing review to determine the overall implications of > including this work. For the current status of this project through > the Apache Incubator, visit: > https://incubator.apache.org/projects/polaris.html"; > > In Fury, the DISCLAIMER says: > > "Apache Fury (Incubating) is an effort undergoing incubation at the Apache > Software Foundation (ASF), sponsored by the Apache Incubator PMC. > > Incubation is required of all newly accepted projects until a further > review > indicates that the infrastructure, communications, and decision making > process > have stabilized in a manner consistent with other successful ASF projects. > > While incubation status is not necessarily a reflection of the completeness > or stability of the code, it does indicate that the project has yet to be > fully endorsed by the ASF." > > Also, in Gravitino (which has been voted recently), the > DISCLAIMER_WIP.txt contains: > > "Apache Gravitino is an effort undergoing incubation at The Apache > Software Foundation (ASF), sponsored by the name of Apache TLP > sponsor. Incubation is required of all newly accepted projects until a > further review indicates that the infrastructure, communications, and > decision-making process have stabilized in a manner consistent with > other successful ASF projects. While incubation status is not > necessarily a reflection of the completeness or stability of the code, > it does indicate that the project has yet to be fully endorsed by the > ASF. > > Some of the incubating project’s releases may not be fully compliant > with ASF policy and while we have documented the licensing of all code > in detail, we know that currently our release would: > - Contains code that may not be compatible with the Apache License > > If you are planning to incorporate this work into your > product/project, please be aware that you will need to conduct a > thorough licensing review to determine the overall implications of > including this work. For the current status of this project through > the Apache Incubator, visit: > https://incubator.apache.org/projects/gravitino.html"; > > So, it's pretty close, but you voted +1 for Fury or Gravitino but -1 > for Polaris. So, I would like to understand what's wrong with Polaris > DISCLAIMER_WIP and fix it if needed (but it's not obvious to me what's > wrong). > > Thanks > Regards > JB > > > On Thu, Feb 13, 2025 at 12:24 AM Justin Mclean <jus...@classsoftware.com> > wrote: > > > > Hi, > > > > -1 (binding) jmclean (IPMC) as the DISCLAIMER text is incorrect > > > > I checked: > > - incubating in name > > - signature and hashes are correct > > - DISCLAIMER_WIP exists but doesn't contain the correct WIP text. It is > unclear why the WIP disclaimer is used here, which is its main purpose. > > - LICENSE is OK > > - NOTICE is OK but is a little confusing as it lists other 3rd party > licensed cored under other OS licenses that are not mentioned in LICENSE. > I’d suggest that unneeded parts of the NOTICE be removed. Some parts of the > NOTICE file have been. It seems a little odd to omit some parts but not > others in this way. [1] > > - ASF files have headers > > - no unexpected binary files > > - can compile from source > > > > Kind Regards, > > Justin > > > > 1. https://github.com/projectnessie/nessie/blob/main/NOTICE > > - > > > > > > >
