-1 binding fanningpj IPMC The license does not mention 3rd party code that appears in the source release.
Examples: Category X GPL licensed code (classpath exception but this is still not allowed for source code) * https://github.com/apache/incubator-wayang/blob/main/docs/script.js * https://github.com/apache/incubator-wayang/blob/main/docs/search.js Ok licenses but not listed in your LICENSE * https://github.com/apache/incubator-wayang/blob/main/docs/jquery/jquery-migrate-3.0.1.js * many more files with JQuery copyright - https://github.com/search?q=repo%3Aapache%2Fincubator-wayang+%22Copyright+jQuery%22&type=code * (c) 2014 Stuart Knightley, David Duponchel MIT/GPL dual licensed * https://github.com/apache/incubator-wayang/tree/main/docs/jquery/jszip-utils/dist (all files) There are loads of python files that are basically empty but with apache license headers. Why do we need all of these? Example: https://github.com/apache/incubator-wayang/blob/main/python/old_code/src/pywy/__init__.py This is not a 100% review. The docs shipped in the source release are the biggest problem but there could be license issues elsewhere and the Wayang PPMC should review the full contents of the source release again. I have also raised some lower priority issues in GitHub issues for incubator-wayang. I don't think you should tag as v1.0.0 until the vote passes. I think this should have been tagged as v1.0.0-RC4 and the v1.0.0 tag added after the vote passes. I would also vote -1 based on the lack of a META-INF/LICENSE and NOTICE in your jars. Example: https://repository.apache.org/content/repositories/orgapachewayang-1021/org/apache/wayang/wayang-core/1.0.0/ wayang-core jar On Thu, 23 Jan 2025 at 22:18, PJ Fanning <fannin...@apache.org> wrote: > > https://downloads.apache.org/incubator/wayang/KEYS has the wrong link > for the KEYS file > > The file contains this > https://dist.apache.org/repos/dist/release/wayang/KEYS (which is 404 Not > Found) > > should be > https://downloads.apache.org/incubator/wayang/KEYS > > Zoi - Can this be corrected? > > On Thu, 23 Jan 2025 at 16:56, sebb <seb...@gmail.com> wrote: > > > > On Thu, 23 Jan 2025 at 09:36, Zoi Kaoudi <zkao...@yahoo.gr.invalid> wrote: > > > > > > Dear all, > > > > > > Apache Wayang (Incubating) 1.0.0 has been staged under [2] and it’s time > > > to vote > > > on accepting it for release. All Maven artifacts are available under [1]. > > > Voting will be open for 72hr. > > > > ... for at least 72 hours. > > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > > > are required to pass. > > > > > > Release tag: v1.0.0 > > > Hash for the release tag (commit r74283): > > > https://github.com/apache/incubator-wayang/releases/tag/v1.0.0 > > > > > > Per [3] "Before voting +1 PPMC members are required to download > > > the signed source code package, compile it as provided, and test > > > the resulting executable on their own platform, along with also > > > verifying that the package meets the requirements of the ASF policy > > > on releases." > > > > The VOTE email needs to include a link to the KEYS file, which should > > be found under > > > > https://downloads.apache.org/incubator/wayang/ > > > > > You can achieve the above by following [4]. > > > > > > [ ] +1 accept (indicate what you validated - e.g. performed the non-RM > > > items in [4]) > > > [ ] -1 reject (explanation required) > > > > > > > > > [1] > > > https://repository.apache.org/content/repositories/orgapachewayang-1021 > > > [2] https://dist.apache.org/repos/dist/dev/wayang/1.0.0/rc4 > > > [3] https://www.apache.org/dev/release.html#approving-a-release > > > [4] > > > https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release > > > > > > Best > > > -- > > > Zoi > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
