Thanks to Justin Mclean. First of all, thank you for reviewing and voting for the candidate version and pointing out the various problems in it, which will play a key role in our correct completion of the release.
Your suggestions on the problems in the candidate version are very pertinent. I will fix these problems before re-releasing the version. 1. Regarding the user list mentioned in the readme, we will add a company introduction link in the display area of the user list to facilitate reviewers to access user company information. 2. Regarding the naming of binary files, if the tar package of the re-released version is too large and still needs to be cut into multiple files, I will name it in a standardized way instead of the -digital suffix method to facilitate user identification and understanding. 3. Regarding the LICENSE and NOTICE of the binary file, there is indeed a lack of description of the third-party dependency license. I will sort out the license information of each module dependency and add it to the LICENSE file for description and explanation, and give the corresponding statement information in the NOTICE file. 4. Regarding the inclusion of category X software, when we re-release the version, we will no longer attach third-party dependency packages to the jar file of the released version, but provide it in the form of an additional dependency file list. For third-party dependencies such as Elasticsearch and MariaDB, the class files of these software will not be directly embedded in the released artifacts, but only used in a dynamic link manner at runtime. We hope that this method will not become an obstacle to version release. At the same time, Elasticsearch is only an option in our project. We provide users with the option to select doris as an alternative storage method through configuration. For the explanation of the above issues, if there are still other questions, please reply and correct them. Thank you for your attention and guidance. Warm regards, Xihui Gao On 2025/01/22 23:56:58 Justin Mclean wrote: > Hi, > > -1 binding jmclean (IPMC) due to issues with the binary release, the source > release looks fine. > > In the source release, I checked: > - incubating in names > - DISCLAIMER exists > - LICENSE and NOTICE are fine > - signatures and hashes are fine > - all ASF files have headers > - no unexpected binary files > - I was unable to compile from source, but that may be my setup > > I am a little concerned by the user list in the README. How does the PMC vet > these companies? > > You could name the two binary files to give a better idea of what each is > rather than using the -1 and -2 postfixes. > > For the binaries the LICENSE and NOTICE fine of the binaries are incorrect as > they fail to mention included 3rd party software. > > Regarding the inclusion of Category X software. ASF projects cannot > distribute software under a Category X license. They can only have it as a > dependency if it is optional in the ASF sense of the word, i.e. that the > majority of users would not use it and need to install it themselves. Has thd > project checked the license of all their dependencies? As it looks like there > are a couple of Category X dependencies from a quick glance Elasticsearch and > MariaDB > > Kind Regards, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
