+1 (binding) * Checked license * Checked the package structure * Checked the README and NOTICE * Compiled from source
On Tue, Jan 7, 2025 at 10:05 PM Liu Xun <liu...@apache.org> wrote: > +1 (binding) from me, > > I have checked the following items: > - Incubating in name > - LICENSE and NOTICE are fine > - DISCLAIMER-WIP exists > - All links are valid > - No unexpected binary files > - All ASF files have ASF headers > - Can compile from source > `mvn clean install` > > Best regards > Xun Liu > > On 2025/01/07 21:48:39 PJ Fanning wrote: > > +1 binding (fanningpj IPMC) > > > > * filenames ok and include 'incubating' > > * asc and sha512 files match > > * archive contents look ok and contain LICENSE, NOTICE and DISCLAIMER > > * LICENSE, NOTICE and DISCLAIMER are ok > > * source headers are ok > > * I didn't compile from source > > > > The NOTICE in the bin tar.gz is very verbose and hard to work out what > text applies to what jar. Some of the verbosity is due to some of the 3rd > party jars have very verbose META-INF/NOTICE files in the their jars. > > > > I think this can improved for future releases but is not a blocker for > this release. > > > > > > > > > > On 2025/01/06 06:02:32 roryqi wrote: > > > +1 (non-binding) > > > > > > I checked > > > Signature is good. > > > License is ok. > > > > > > 。。。 <hgfds4...@qq.com.invalid> 于2025年1月3日周五 23:31写道： > > > > > > > general-unsubscr...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
