+1 (binding), I have checked: - download links are ok - sigs and checksums are ok - DISCLAIMER (WIP) exists - LICENSE and NOTICE files are ok - no binary in source releases
Kent Yao 在 2024年12月11日星期三，Weiting Chen <weitingc...@apache.org> 写道： > /gluten-core/src/main/resources/substrait/proto/substrait/ddl.proto > /cpp-ch/local-engine/Parser/scalar_function_parser/empty2null.cpp > > These two files were previously overlooked and will have headers added in > the next version. > > /dev/vcpkg > > vcpkg is a toolkit designed to help manage c++ packages, which is why the > directory contains numerous cmake and script files. > > On 2024/12/10 06:51:05 Felix Cheung wrote: > > +1 (binding) > > > > checked: > > - signature ok > > - DISCLAIMER (WIP) ok > > - license and notice ok > > - Apache header ok > > should these files have the header? > > /gluten-core/src/main/resources/substrait/proto/substrait/ddl.proto > > /cpp-ch/local-engine/Parser/scalar_function_parser/empty2null.cpp > > > > what is the source of /dev/vcpkg? > > > > > > On Thu, Dec 5, 2024 at 6:26 PM Zhen Wang <wangz...@apache.org> wrote: > > > > > Forwarding my vote from the dev thread. > > > > > > +1 > > > > > > Kind Regards, > > > Zhen Wang > > > > > > Chang Chen <changc...@apache.org> 于2024年12月4日周三 17:56写道： > > > > > > > > +1 > > > > > > > > On 2024/12/04 05:45:28 WeitingChen wrote: > > > > > Hi everyone, > > > > > > > > > > > > > > > This is a call for a vote to release Apache Gluten (Incubating) > > > > > version 1.2.1 release candidate 0. > > > > > > > > > > > > > > > The Apache Gluten community has voted and approved the release of > > > > > Apache Gluten(incubating) v1.2.1-RC0. > > > > > > > > > > > > > > > We ask the IPMC members to review and vote for this release. > > > > > > > > > > > > > > > Apache Gluten is a middle layer that offloads JVM-based SQL > engines' > > > > > execution to native engines. > > > > > > > > > > > > > > > Apache Gluten community Vote thread: > > > > > https://lists.apache.org/thread/kgvgb47oz107z312c7clfx1k53m3czm5 > > > > > > > > > > > > > > > Apache Gluten community Vote Result thread: > > > > > https://lists.apache.org/thread/633bkg8qr269d5ly78s6n47hmrjrvnm7 > > > > > > > > > > > > > > > The release candidates: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gluten/1.2. > 1-incubating-rc0 > > > > > > > > > > > > > > > Release notes: > > > https://github.com/apache/incubator-gluten/releases/tag/v1.2.1-rc0 > > > > > > > > > > > > > > > Git tag for the release: > > > > > https://github.com/apache/incubator-gluten/releases/tag/v1.2.1-rc0 > > > > > > > > > > > > > > > Git commit ID for the release: > > > > > > > > https://github.com/apache/incubator-gluten/commit/ > 1a50a68ff1fe7040454bc1784a907a48e63d67a3 > > > > > > > > > > > > > > > Keys to verify the Release Candidate: > > > > > https://downloads.apache.org/incubator/gluten/KEYS > > > > > > > > > > > > > > > To compile from the source, please refer to: > > > > > > > > https://github.com/apache/incubator-gluten/blob/main/ > docs/get-started/Velox.md > > > > > > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > > > > number of votes is reached. Please vote accordingly: > > > > > > > > > > [ ] +1 approve > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > Checklist for reference: > > > > > > > > > > [ ] Download links are valid. > > > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > > > [ ] Source code distributions have correct names matching the > current > > > release. > > > > > > > > > > [ ] LICENSE and NOTICE files are accurate for each Apache Gluten > repo. > > > > > > > > > > [ ] All files have license headers if necessary. > > > > > > > > > > [ ] No unlicensed compiled archives are bundled in the source > archive. > > > > > > > > > > > > > > > Thanks, > > > > > Weiting Chen > > > > > > > > > > ------------------------------------------------------------ > --------- > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > ------------------------------------------------------------ > --------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
