Re: point 2 (I may be missing something but to me it looks like new
jars in the docker image):
$ docker ps
CONTAINER ID IMAGE COMMAND CREATED
STATUS PORTS
NAMES
4ce4ddbaf9d1 hugegraph/hugegraph "/usr/bin/dumb-init …" 2
minutes ago Up 2 minutes 0.0.0.0:8080->8080/tcp, :::8080->8080/tcp
graph
$ docker exec -it graph bash
root@4ce4ddbaf9d1:/hugegraph-server# ls lib
...
hugegraph-api-1.5.0.jar
hugegraph-cassandra-1.5.0.jar
hugegraph-common-1.5.0.jar
hugegraph-core-1.5.0.jar
hugegraph-dist-1.5.0.jar
hugegraph-hbase-1.5.0.jar
hugegraph-hstore-1.5.0.jar
hugegraph-mysql-1.5.0.jar
hugegraph-palo-1.5.0.jar
hugegraph-postgresql-1.5.0.jar
hugegraph-rocksdb-1.5.0.jar
hugegraph-rpc-1.5.0.jar
hugegraph-scylladb-1.5.0.jar
...
Cheers, Paul.
On Sun, Dec 8, 2024 at 11:07 PM Yuchen Ding <vgalax...@apache.org> wrote:
>
> Hi Paul,
>
> Thank you for your feedback and support!
>
> Regarding the caveats:
>
> 1. For the issue with the Gremlin examples not running as expected, this may
> be related to recent changes we made. We appreciate your observation and
> encourage you to report this in our main repo issue so we can reproduce and
> address it promptly.
> 2. The release version shown in the README example is because we made a bulk
> replacement of the version number while modifying the pom file. However, we
> did not actually push it (image) before the release done. Thank you for
> pointing this out, we’ll ensure the README content is only updated after the
> vote finished to avoid confusion.
> 3. The swagger-ui files are indeed under the Apache-2.0 license, but we
> overlooked standalone files like swagger-ui.css while focusing on jar
> dependencies. We’ll address it & check similar files.
>
> Thanks again for your detailed review and valuable insights!
>
> Best regards,
> VGalaxies
>
> On 2024/12/08 03:02:38 Paul King wrote:
> > +1 (binding) with caveats
> >
> > I checked:
> > * Checksum and GPG signatures are OK
> > * LICENSE, NOTICE, DISCLAIMER exist
> > * Incubating in name
> > * No unexpected binary files in src tar.gz files (I checked mostly the
> > main tar.gz file)
> > * Server from convenience binaries ran fine on macOS 15.1.1
> > * Compiled from source was successful with Java 17.0.3, Maven 3.9.9
> > * I ran the code from my groovy-graphdb blog which uses Groovy and
> > HugeGraph:
> > https://groovy.apache.org/blog/groovy-graph-databases
> > https://github.com/paulk-asert/groovy-graphdb/tree/main/hugegraph
> >
> > Caveats:
> > * When running the code from the blog post mentioned above, the server
> > didn't seem to have Gremlin support even though I thought my
> > gremlin-server.yaml file and rest-server.properties files did have it
> > configured (might be something I missed locally):
> > gremlin-groovy is not an available GremlinScriptEngine
> > Non-gremlin examples ran fine.
> > * When running against the current docker image the examples ran fine
> > (though I was surprised that the docker image was 1.5.0 even though
> > the vote hasn't passed as yet). I believe the docker image should only
> > be published after the vote has passed. I know docker images can be
> > updated at any time, so I didn't see this as blocking.
> > * While the work done for license/notice files looks excellent in
> > general, there still seems to be some things missing, e.g.
> > swagger-ui.css has MIT license, but that doesn't seem to be reflected
> > in current license files. Diligent observers of the convenience binary
> > release would find the MIT License info, so I didn't see this as
> > blocking, but this should ideally be fixed for the next release. There
> > might be more files like this where things need updating, that file is
> > just the first I noticed.
> >
> > On Thu, Dec 5, 2024 at 2:21 AM VGalaxies <vgalax...@apache.org> wrote:
> > >
> > > Hello Incubator Community,
> > >
> > > This is a call for a vote to release Apache HugeGraph (Incubating)
> > > version 1.5.0-rc3
> > >
> > > The Apache HugeGraph community has voted on and approved a proposal to
> > > release Apache HugeGraph(Incubating) version 1.5.0-rc3
> > >
> > > In this release, we fixed a string of problems mentioned by Justin Mclean:
> > > 1. Exclude the style directory from the hugegraph-ai source package
> > > and add proper ASF headers to its files.
> > > 2. Fix the incorrect LICENSE file from the hugegraph-ai source package.
> > > 3. Upgrade the org.json:json dependency in the main repository to a
> > > version under the "Public Domain" license, ensuring ALv2 compatibility
> > > (we confirm that this dependency is only for test scope, so there is
> > > no need to declare it in binary LICENSE).
> > >
> > > We now kindly request the Incubator PMC members review and vote on
> > > this incubator release.
> > >
> > > HugeGraph community vote thread:
> > > • https://lists.apache.org/thread/jfcr2vlrwn7bzmg32d8ljqpmc6794vj0
> > >
> > > Vote result thread:
> > > • https://lists.apache.org/thread/mrywryb99l7n75g7voqp8n0bk7wnlx5k
> > >
> > > The release candidate:
> > > • https://dist.apache.org/repos/dist/dev/incubator/hugegraph/1.5.0
> > >
> > > Git tag & Commit hash for the release:
> > > • https://github.com/apache/incubator-hugegraph/tree/1.5.0-rc3 (8b90977)
> > > • https://github.com/apache/incubator-hugegraph-toolchain/tree/1.5.0-rc3
> > > (4b89c5d)
> > > • https://github.com/apache/incubator-hugegraph-computer/tree/1.5.0-rc3
> > > (1a0352e)
> > > • https://github.com/apache/incubator-hugegraph-ai/tree/1.5.0-rc3
> > > (ef56263)
> > >
> > > Keys to verify the Release Candidate:
> > > • https://downloads.apache.org/incubator/hugegraph/KEYS
> > >
> > > The release GPG user ID: VGalaxies <vgalax...@apache.org>
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> > > number of votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > More detail checklist please refer:
> > > •
> > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > >
> > > Steps to validate the release，Please refer to:
> > > •
> > > https://hugegraph.apache.org/docs/contribution-guidelines/validate-release/
> > > (EN)
> > > •
> > > https://hugegraph.apache.org/cn/docs/contribution-guidelines/validate-release/
> > > (CN)
> > >
> > >
> > > Thanks,
> > > On behalf of Apache HugeGraph (Incubating) community
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
