I'm changing my vote to -1 based on Justin's feedback. I'm cancelling the
vote. Fixes made[0]. I'll restart an RC#3 shortly.
If there's anything else we need to do, please let us know before I roll
RC#3 in a few hours. Thank you.
Best,
Tim
[0]
https://github.com/apache/incubator-stormcrawler/commit/30f9e9d004f6e79396f081ad84551f52c62fd67b
On Thu, Nov 28, 2024 at 7:06 PM Justin Mclean <jus...@classsoftware.com>
wrote:
> HI,
>
> Sorry, but it is still -1 (binding) jmclean (IPMC).
>
> The release contains a Blogger Template Style called Thisaway (Blue)
> designed by Dan Rubin. [1] How is this licensed? Should this file have an
> ASF header? It is also unclear how this file is licensed [2]. Should it
> have an ASF header? (This was mentioned in my previous review.)
>
> Digitka Pebbel still occurs in multiple files. [3][4][5][6][7][8][9]
>
> Kind Regards,
> Justin
>
> 1. ./core/src/test/resources/stackexception.html
> 2. ./core/src/test/resources/longtext.html
> 3. ./core/src/test/resources/stormcrawler.sitemap.extensions.all.xml
> 4.
> ./core/src/main/java/org/apache/stormcrawler/filtering/regex/FastURLFilter.java
> 5.
> ./core/src/main/java/org/apache/stormcrawler/persistence/DefaultScheduler.java
> 6.
> ./external/opensearch/archetype/src/main/resources/archetype-resources/opensearch-conf.yaml
> 7. ./external/opensearch/opensearch-conf.yaml
> 8.
> ./external/tika/src/test/java/org/apache/stormcrawler/tika/ParserBoltTest.java
> 9 ./external/sql/README.md
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
