Hi Justin, Thank you for your feedback.
Regarding the missing ASF header, the files in the style directory do not need to be included in the source package. In the new release, we will exclude this directory, and we have also added proper headers to the files[1]. The LICENSE file you referred to was mistakenly included in the hugegraph-ai source package. It is intended for a future binary release, as the AI project is still under development and does not currently release the binary package. We noticed this issue shortly before the release, but the corresponding PR[2] was not merged in time. For the JSON license issue in binary release for main repo, we have upgraded the corresponding dependency to a version that uses the "Public Domain" license, to ensure compatibility with ALv2. Please feel free to check them. If there are any further issues, you can provide feedback at any time. I will close the current vote and prepare for the next round. Best regards, VGalaxies Refer: 1. https://github.com/apache/incubator-hugegraph-ai/pull/118/files 2. https://github.com/apache/incubator-hugegraph-ai/pull/104/files On 2024/11/23 01:31:58 Justin Mclean wrote: > Hi, > > -1 (binding) from jmclean (IPMC) > > in the main source release I checked: > - incubating in artifact names > - signatures and hashes are fine > - DISCLAIMER exists > - LICENSE and NOTICE are fine > - No unexpected binary files > - ASF files have headers > - Didn’t compile from source > > And everything is fine there, but there are issues with some of the other > release artifacts. > > In the AI package [1] is missing an ASF header, and the LICENSE file need > work, as you are misisng a copy of 3rd party licenses. Are these 3rd party > software even included in the release? > > The binary release includes software under a license incompatible with the > ALv2, namely the JSON license. > > Kind Regards, > Justin > > 1. ./style/code_format_and_analysis.sh > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
