Hi, +1 (binding) but only due to the disclaimer WIP.
Some more work is needed here as per the WIP disclaimer [1], some of which I’d expect before the next release. There is also the outstanding license issue [2] I checked: - incubating release names - signatures and hashes are correct - LICENSE and NOTICE need some work (see below) - DISCLAIMER exists (WIP) - ASF files have correct headers - No unexpected binary files - Can compile from source The LICENSE refers to many files whose path is not correct: ./spark-connector/spark-connector/src/test/java/org/apache/gravitino/spark/connector/integration/test/util/SparkUtilIT.java ./catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/CachedClientPool.java ./catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveClientPool.java ./catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/dyn/DynConstructors.java ./catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/dyn/DynFields.java ./catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/dyn/DynMethods.java ./catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/miniHMS/MiniHiveMetastore.java ./catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/miniHMS/MiniHiveMetastoreService.java ./catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/miniHMS/ScriptRunner.java ./catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/TestCachedClientPool.java ./catalogs/catalog-hive/src/test/resources/hive-schema-3.1.0.derby.sql ./integration-test/src/test/resources/run ./catalogs/catalog-kafka/src/test/resources/run ./trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/hive/SortingColumn.java ./clients/client-python/gravitino/utils/exceptions.py ./security-admin/src/main/java/org/apache/ranger/defines/JsonDateSerializer.java ./security-admin/src/main/java/org/apache/ranger/defines/RangerCommonEnums.java ./security-admin/src/main/java/org/apache/ranger/view/VList.java ./security-admin/src/main/java/org/apache/ranger/view/VXDataObject.java ./security-admin/src/main/java/org/apache/ranger/view/VXGroup.java ./security-admin/src/main/java/org/apache/ranger/view/VXGroupList.java ./security-admin/src/main/java/org/apache/ranger/view/VXUser.java ./security-admin/src/main/java/org/apache/ranger/view/VXUserList.java gradlew is listed as coming from Apache Iceberg, but that is not the original source, according to its header. The Apache Ranger files are incorrectly listed as MIT licensed. The LICENSE also seems to be missing a license for: ./clients/client-python/gravitino/utils/http_client.py (MIT licensed) There are probably other files as well whose license is missing e.g. I would expect to see tpcds mentioned in the license file. The NOTICE file is missing mention of Apache Paimon and Apache Ranger. The binary releases also needs updates to their LICENSE and NOTICE files. Kind Regards, Justin 1. https://issues.apache.org/jira/browse/LEGAL-469 2 https://issues.apache.org/jira/browse/LEGAL-678 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
