+1 binding

* Download link valid
* Checksum and signature matches
* LICENSE and NOTICE exist
* DISCLAIMER exists
* Build Rust lib successfully (cargo build)
* Build Java lib successfully (mvn clean install)

Best,
tison.


Ayush Saxena <ayush...@gmail.com> 于2024年7月23日周二 14:07写道:

> +1 (Binding)
>
> * Built java module from source
> * Validated Checksums
> * Validated Signatures
> * Validated incubating in name
> * NOTICE & DISCLAIMER file exists
> * Validated license header on source files
> * Validated diff b/w the git tag & src tar (java/benchmark only in git
> tag, looks intentional)
> * No unexpected binary files
>
> Good Luck!!!
>
> -Ayush
>
> On Mon, 22 Jul 2024 at 17:33, Xin Wang <data.xinw...@gmail.com> wrote:
> >
> > +1 binding
> >
> > [x] Download links are valid.
> > [x] Checksums and signatures.
> > [x] LICENSE/NOTICE files exist
> > [x] No unexpected binary files
> > [x] All source files have ASF headers
> > [x] Can compile from source for Java
> >
> >
> > Shawn Yang <shawn.ck.y...@gmail.com> 于2024年7月21日周日 13:38写道:
> >
> > > Thanks for pointing this out, let's discuss it in this github issue.
> > >
> > > On Sat, Jul 20, 2024 at 11:45 PM PJ Fanning <fannin...@apache.org>
> wrote:
> > > >
> > > > +1 binding
> > > >
> > > > * download ok
> > > > * asc and sha512 files ok
> > > > * file names ok
> > > > * LICENSE/NOTICE/DISCLAIMER ok
> > > > * license headers on source files
> > > > * no unexpected binary files
> > > >
> > > > I raised an issue about the license file in the jars but I don't
> think
> > > > it is a release blocker.
> > > > https://github.com/apache/fury/issues/1745
> > > >
> > > >
> > > > On Sat, 20 Jul 2024 at 15:19, Shawn Yang <shawn.ck.y...@gmail.com>
> > > wrote:
> > > > >
> > > > > Hi PJ,
> > > > >
> > > > > Seems it's a network issue on my computer. I've reuploaded the
> jars in
> > > > >
> https://repository.apache.org/content/repositories/orgapachefury-1043/
> > > > >
> > > > > The pom.xml and jars are fine, could you help check it again?
> > > > >
> > > > >
> > > > > On Sat, Jul 20, 2024 at 7:32 PM PJ Fanning <fannin...@apache.org>
> > > wrote:
> > > > >
> > > > > > The RC looks mainly correct but I see one set of issues so I will
> > > > > > temporarily vote -1 binding (which I will withdraw if the issues
> are
> > > > > > fixed).
> > > > > >
> > > > > > The main jar and pom are missing in
> > > > > >
> > > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachefury-1014/org/apache/fury/fury-core/0.6.0/
> > > > > >
> > > > > > I would suggest that the jars are 'staged' in future by
> 'closing' the
> > > > > > repository. There is a further 'release' stage but this should
> only
> > > be
> > > > > > done after the vote happens. Closing the repository will perform
> > > > > > checks on the repository and these would likely have found the
> issue
> > > > > > with missing jar and pom.
> > > > > >
> > > > > >
> > > > > > On Sat, 20 Jul 2024 at 06:15, Shawn Yang <
> shawn.ck.y...@gmail.com>
> > > wrote:
> > > > > > >
> > > > > > > Hello everyone,
> > > > > > >
> > > > > > > This is a call for the vote to release Apache Fury(Incubating)
> > > > > > v0.6.0-rc1.
> > > > > > >
> > > > > > > The Apache Fury community has voted and approved the release of
> > > Apache
> > > > > > > Fury(incubating) v0.6.0-rc1. We now kindly request the IPMC
> members
> > > > > > > review and vote for this release.
> > > > > > >
> > > > > > > Apache Fury(incubating) - A blazingly fast multi-language
> > > serialization
> > > > > > > framework powered by JIT and zero-copy.
> > > > > > >
> > > > > > > Fury community vote thread:
> > > > > > >
> https://lists.apache.org/thread/ktz73l7bzyhj7f4dpvqtf4nbq8od57ps
> > > > > > >
> > > > > > > Vote result thread:
> > > > > > >
> https://lists.apache.org/thread/oxcz6ytt5z44ndb5zjthh5kvn4mg6x0n
> > > > > > >
> > > > > > > The release candidate:
> > > > > > >
> https://dist.apache.org/repos/dist/dev/incubator/fury/0.6.0-rc1/
> > > > > > >
> > > > > > > This release has been signed with a PGP available here:
> > > > > > > https://downloads.apache.org/incubator/fury/KEYS
> > > > > > >
> > > > > > > Git tag for the release:
> > > > > > > https://github.com/apache/fury/releases/tag/v0.6.0-rc1
> > > > > > >
> > > > > > > Git commit for the release:
> > > > > > >
> > > > > >
> > >
> https://github.com/apache/fury/commit/243e99876379cdb4ac9c4a495187b5458ae4e0e4
> > > > > > >
> > > > > > > Maven staging repo:
> > > > > > >
> > > https://repository.apache.org/content/repositories/orgapachefury-1014
> > > > > > >
> > > > > > > How to Build and Test, please refer to:
> > > > > > >
> https://github.com/apache/fury/blob/main/docs/guide/DEVELOPMENT.md
> > > > > > >
> > > > > > > Please download, verify, and test.
> > > > > > >
> > > > > > > The VOTE will pass after 3 binding approve.
> > > > > > >
> > > > > > > [ ] +1 approve
> > > > > > > [ ] +0 no opinion
> > > > > > > [ ] -1 disapprove with the reason
> > > > > > >
> > > > > > > To learn more about apache fury, please see
> > > https://fury.apache.org/
> > > > > > >
> > > > > > > Checklist for reference:
> > > > > > >
> > > > > > > [ ] Download links are valid.
> > > > > > > [ ] Checksums and signatures.
> > > > > > > [ ] LICENSE/NOTICE files exist
> > > > > > > [ ] No unexpected binary files
> > > > > > > [ ] All source files have ASF headers
> > > > > > > [ ] Can compile from source
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Chaokun Yang
> > > > > >
> > > > > >
> ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > > > For additional commands, e-mail:
> general-h...@incubator.apache.org
> > > > > >
> > > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> > --
> > Thanks,
> > Xin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to