+1 binding

* Download link valid.
* Signature and checksum matches

apache-horaedb-incubating-rust-client-v2.0.0-src.tar.gz
gpg: Signature made 二  6/11 20:05:04 2024 PDT
gpg:                using RSA key 6F734AE4297C7F62B6054F91D3026E5C08A0BAB4
gpg: Good signature from "jiacai2...@apache.org" [unknown]
gpg:                 aka "Jiacai Liu <he...@liujiacai.net>" [unknown]
gpg:                 aka "Jiacai Liu <d...@liujiacai.net>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 6F73 4AE4 297C 7F62 B605  4F91 D302 6E5C 08A0 BAB4

* LICENSE / NOTICE / DISCLAIMER exists
* License header properly set.
* Build works with: cargo build

To @PJ:
> maturin build failed on my Macbook

You may misread the build instructions of Python client, this is the Rust
client.

But I suggest the PPMC try add a default target of Makefile to let `make`
build the library which is intuitive since you have the Makefile.

Best,
tison.


PJ Fanning <fannin...@apache.org> 于2024年7月7日周日 16:20写道:

> +1 binding
> * Downloads ok
> * checksums and signatures are valid
> * no binaries
> * LICENSE/NOTICE/DISCLAIMER ok
> * Source headers ok
> * maturin build failed on my Macbook
>
> Caused by: Couldn't detect the binding type; Please specify them with
> --bindings/-b
>
> I'm no Rust expert but the build made some progress and everything
> else seems ok.
>
> On Tue, 2 Jul 2024 at 13:42, hulk <hulk.webs...@gmail.com> wrote:
> >
> > +1 binding
> >
> > I checked:
> >
> > [x] Download links are valid.
> > [x] Checksums and PGP signatures are valid.
> > [x] [No unexpected binary files bundled in the source archive.
> > [x] LICENSE/NOTICE/DISCLAIMER files exist.
> > [x] Can compile from source.
> >
> >    Compiling horaedb-client v2.0.0
> > (/Users/hulk/Downloads/apache-horaedb-incubating-rust-client-v2.0.0-src)
> >     Finished dev [unoptimized + debuginfo] target(s) in 54.31s
> >
> > On Tue, 2 Jul 2024 at 16:46, Jiacai Liu <d...@liujiacai.net> wrote:
> >
> > > Hello,
> > >
> > > This is a call for a vote to release Apache HoraeDB(incubating)
> > > rust client version v2.0.0.
> > >
> > > The tag to be voted on is v2.0.0-rc.1
> > >
> > > The vote thread:
> > > https://lists.apache.org/thread/yr6plq4176d5xyh1v0h2pjtgt61rkrb6
> > >
> > > Vote Result:
> > > https://lists.apache.org/thread/nvnpxnbf96b7dj05lwdp9knv2d3wklws
> > >
> > > The release candidate:
> > >
> > >
> > >
> https://dist.apache.org/repos/dist/dev/incubator/horaedb/horaedb-rust-client/v2.0.0-rc.1/
> > >
> > > Keys to verify the release candidate:
> > >
> > > https://downloads.apache.org/incubator/horaedb/KEYS
> > >
> > > Git tag for the release:
> > >
> > > https://github.com/apache/horaedb-client-rs/releases/tag/v2.0.0-rc.1
> > >
> > > Git commit id for the release:
> > >
> > >
> https://github.com/apache/horaedb-client-rs/commit/c011a7ef4726272fe73026a96583d0271fce6f3d
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> > > number
> > > of votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Checklist for reference:
> > > [ ] Download links are valid.
> > > [ ] Checksums and PGP signatures are valid.
> > > [ ] Source code distribution has correct names matching the
> > > current release.
> > > [ ] LICENSE/NOTICE files exist and are correct.
> > > [ ] No unexpected binary files bundled in the source archive.
> > > [ ] All source files have ASF headers.
> > > [ ] Can compile from source.
> > >
> > > Tips to verify the release, please refer to:
> > >
> > > https://github.com/apache/horaedb/wiki/ASF-review-guide
> > >
> > > How to Build HoraeDB Rust client, please refer to:
> > >
> > > https://horaedb.apache.org/dev/sdk_develop.html#rust
> > >
> > > Best,
> > > Jiacai Liu
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to