Hi John, Thanks for your detailed replyment. I didn't know that flink has a build stage to aggregate license files into the final license. I'll update the license and notice file later. Thanks for your reminder.
Best regards, Chaokun Yang On Sat, Apr 13, 2024 at 8:55 PM John D. Ament <johndam...@apache.org> wrote: > On Sat, Apr 13, 2024 at 1:54 AM Shawn Yang <shawn.ck.y...@gmail.com> > wrote: > > > Dear Community, > > > > I'm fixing the license issue of Apache Fury to comply with ASF > requirements > > for the first release for Fury under ASF. > > > > Currently we borrowed some code from other projects such as > > v8-fast-api-calls.h[1] in v8 and Preconditions[2] in guava. We mentioned > > their license in our NOTICE file[3]. > > > > I'm wondering whether we should move those mentions into the LICENSE > file, > > and mention the NOTICE of those projects in our NOTICE instead. > > > > The NOTICE file is to be used to aggregate any notices you have. It is > fine to mention that you're using something in your NOTICES file, including > original sources for the content. The licenses those for those files needs > to be in your license file. Here's an example from another project [1] > [2]. > > [1]: https://github.com/apache/daffodil/blob/main/LICENSE#L359-L387 > [2]: https://github.com/apache/daffodil/blob/main/NOTICE > > > > > > I did some research, but didn't know which is better: > > 1) Projects like flink[4] and pytorch[5] mention the license of other > > projects in the NOTICE file. > > > > Looking at flink (I can't speak to non-ASF projects) what they do is fine. > They don't store all of the licenses in the main license file, instead they > have a subdirectory and during their build they aggregate the license files > together to produce the final license. It's important to remember that we > evaluate based on the source release contents, not the git repository > layout. > > > > 2) But other projects such as spark[6] and arrow[7] all put the mentions > > into the `LICENSE` file. > > > > Are those both ways legal? Do we have a best practice here? > > > > 1. > > > > > https://github.com/apache/incubator-fury/blob/main/javascript/packages/hps/src/v8-fast-api-calls.h > > 2. > > > > > https://github.com/apache/incubator-fury/blob/main/java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java > > 3. https://github.com/apache/incubator-fury/blob/main/NOTICE > > 4. https://github.com/apache/opendal/blob/master/NOTICE > > 5. https://github.com/pytorch/pytorch/blob/main/NOTICE > > 6. https://github.com/apache/spark/blob/master/LICENSE > > 7. tttps://github.com/apache/arrow/blob/main/LICENSE.txt > > > > > > Best regards, > > Chaokun Yang > > >
