> 2. How do you define "binary file"? The files listed are configuration > files and cannot be executed.
Hi, please double check this part. They are all hidden files start with ".". For example, "._.asf.yaml" instead of ".asf.yaml". They should not exist. On Fri, Mar 29, 2024, at 16:06, Chunshao Ren wrote: > Thanks for your verification! > > 1. "src/components/skiplist/src/key.rs" is modified from > alatedb(https://github.com/tikv/agatedb), detailed information can be > found at > https://github.com/apache/incubator-horaedb/blob/main/NOTICE#L30 > > 2. How do you define "binary file"? The files listed are configuration > files and cannot be executed. > > 3. Fail to compile from source: > It may be a problem with the gcc version. You can try gcc 8. We will > bump our dependency in the next release to support newer gcc versions. > See https://github.com/apache/incubator-horaedb/issues/1506 for details. > > On 2024/03/28 11:05:49 Xuanwo wrote: >> Hi, I have checked the following and found some issues. >> >> [x] Download links are valid. >> [x] Checksums and signatures. >> >> gpg: Signature made Tue 19 Mar 2024 02:21:30 PM CST >> gpg: using RSA key 8BF38B1BBF93AD717DD63948F3EA26DA0F715C7F >> gpg: checking the trustdb >> gpg: marginals needed: 3 completes needed: 1 trust model: pgp >> gpg: depth: 0 valid: 24 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 24u >> gpg: next trustdb check due at 2024-05-25 >> gpg: Good signature from "chunshao.rcs <chuns...@apache.org>" [ultimate] >> apache-horaedb-incubating-v2.0.0-src.tar.gz: OK >> >> [x] LICENSE/NOTICE files exist >> [-] No unexpected binary files >> >> I have seen many hidden binary files like >> >> - ._.asf.yaml >> - .asf.yaml >> - ._Cargo.lock >> - ._Cargo.toml >> - ._clippy.toml >> - ._CONTRIBUTING.md >> - ._DEPENDENCIES.tsv >> >> Please check the package tool and remove them >> >> [-] All source files have ASF headers >> >> I have seen files like "src/components/skiplist/src/key.rs" been excluded >> from >> license check, is there a reason for this? >> >> By the way, I recommend relying on released tags rather than individual >> commits >> in github. >> >> [-] Can compile from source >> >> cargo build failed for: >> >> ``` >> 1470 | return std::move(status); >> | ~~~~~~~~~^~~~~~~~ >> >> /home/xuanwo/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1470:19: >> note: remove ‘std::move’ call >> cc1plus: all warnings being treated as errors >> make[3]: *** [CMakeFiles/rocksdb.dir/build.make:555: >> CMakeFiles/rocksdb.dir/db/db_impl/db_impl.cc.o] Error 1 >> make[2]: *** [CMakeFiles/Makefile2:142: CMakeFiles/rocksdb.dir/all] Error 2 >> make[1]: *** [CMakeFiles/Makefile2:149: CMakeFiles/rocksdb.dir/rule] Error >> 2 >> make: *** [Makefile:172: rocksdb] Error 2 >> thread 'main' panicked at >> /home/xuanwo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5: >> >> command did not execute successfully, got: exit status: 2 >> ``` >> >> Maybe we should supress the warnings? >> >> On Wed, Mar 27, 2024, at 11:47, 任春韶 wrote: >> > I'm sorry, there was a problem with the formatting of the email I sent just >> > now.😅 >> > >> > Hello, Incubator Community, >> > >> > This is a call for a vote to release Apache HoraeDB(incubating) version >> > v2.0.0-RC5 >> > >> > HoraeDB PPMC Vote Thread >> > https://lists.apache.org/thread/trvhct3nqgkqkb5mxg4sy26gkn90d31v >> > >> > HoraeDB PPMC Vote Result >> > https://lists.apache.org/thread/p6tkbnvt7wrx956d87h077nbls2yls1r >> > >> > The release candidate: >> > https://dist.apache.org/repos/dist/dev/incubator/horaedb/horaedb/v2.0.0-rc.5 >> > >> > >> > This release has been signed with a PGP available here: >> > https://downloads.apache.org/incubator/horaedb/KEYS >> > >> > Git tag for the release >> > https://github.com/apache/incubator-horaedb/releases/tag/v2.0.0-rc.5 >> > >> > Please download, verify, and test. >> > >> > The VOTE will pass after got 3 binding approve. >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove with the reason >> > >> > To learn more about Apache HoraeDB, please see https://horaedb.apache.org/ >> > >> > Checklist for reference: >> > >> > [ ] Download links are valid. >> > [ ] Checksums and signatures. >> > [ ] LICENSE/NOTICE files exist >> > [ ] No unexpected binary files >> > [ ] All source files have ASF headers >> > [ ] Can compile from source >> > >> > Thanks >> > >> > 任春韶 <chuns...@apache.org> 于2024年3月27日周三 11:38写道： >> > >> >> Hello, Incubator Community, This is a call for a vote to release Apache >> >> HoraeDB(incubating) version v2.0.0-RC5 HoraeDB PPMC Vote Thread >> >> https://lists.apache.org/thread/trvhct3nqgkqkb5mxg4sy26gkn90d31v HoraeDB >> >> PPMC Vote Result >> >> https://lists.apache.org/thread/p6tkbnvt7wrx956d87h077nbls2yls1r The >> >> release candidate: >> >> https://dist.apache.org/repos/dist/dev/incubator/horaedb/horaedb/v2.0.0-rc.5 >> >> This release has been signed with a PGP available here: >> >> https://downloads.apache.org/incubator/horaedb/KEYS Git tag for the >> >> release: >> >> https://github.com/apache/incubator-horaedb/releases/tag/v2.0.0-rc.5 >> >> Please download, verify, and test. The VOTE will pass after got 3 binding >> >> approve. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the >> >> reason >> >> To learn more about Apache HoraeDB, please see https://horaedb.apache.org/ >> >> Checklist for reference: [ ] Download links are valid. [ ] Checksums and >> >> signatures. [ ] LICENSE/NOTICE files exist [ ] No unexpected binary files >> >> [ >> >> ] All source files have ASF headers [ ] Can compile from source Thanks >> >> >> >> -- >> Xuanwo >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org -- Xuanwo --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
