Hi, Jacky Yang

This release looks good to me over all, but have some small issues to address.

I believe they can be fixed in next release, so I will give a +1 binding for 
this one.

The checks I performed:

[x] Download links are valid.

a small issue: https://github.com/apache/incubator-hugegraph/tree/1.3.0 is a 
broken link.

[x] Checksums and signatures.

gpg: Signature made Mon 25 Mar 2024 02:40:14 PM CST
gpg:                using RSA key 12CEB4C81B4F1E358B8A1A181B75F4C00CAB214C
gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:  25  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 25u
gpg: next trustdb check due at 2024-05-25
gpg: Good signature from "JackyYang <yangji...@apache.org>" [ultimate]
apache-hugegraph-ai-incubating-1.3.0-src.tar.gz: OK
gpg: Signature made Sun 24 Mar 2024 05:48:23 PM CST
gpg:                using RSA key 12CEB4C81B4F1E358B8A1A181B75F4C00CAB214C
gpg: Good signature from "JackyYang <yangji...@apache.org>" [ultimate]
apache-hugegraph-commons-incubating-1.3.0-src.tar.gz: OK
gpg: Signature made Sun 24 Mar 2024 06:21:51 PM CST
gpg:                using RSA key 12CEB4C81B4F1E358B8A1A181B75F4C00CAB214C
gpg: Good signature from "JackyYang <yangji...@apache.org>" [ultimate]
apache-hugegraph-incubating-1.3.0-src.tar.gz: OK
gpg: Signature made Sun 24 Mar 2024 06:21:52 PM CST
gpg:                using RSA key 12CEB4C81B4F1E358B8A1A181B75F4C00CAB214C
gpg: Good signature from "JackyYang <yangji...@apache.org>" [ultimate]
apache-hugegraph-incubating-1.3.0.tar.gz: OK
gpg: Signature made Sun 24 Mar 2024 06:49:03 PM CST
gpg:                using RSA key 12CEB4C81B4F1E358B8A1A181B75F4C00CAB214C
gpg: Good signature from "JackyYang <yangji...@apache.org>" [ultimate]
apache-hugegraph-toolchain-incubating-1.3.0-src.tar.gz: OK
gpg: Signature made Sun 24 Mar 2024 06:49:05 PM CST
gpg:                using RSA key 12CEB4C81B4F1E358B8A1A181B75F4C00CAB214C
gpg: Good signature from "JackyYang <yangji...@apache.org>" [ultimate]
apache-hugegraph-toolchain-incubating-1.3.0.tar.gz: OK

[x] LICENSE/NOTICE files exist

a small issue: the LICENSE, NOTICE, and DISCLAIMER files all incorrectly have 
execute permissions on Linux platforms in apache-hugegraph-incubating-1.3.0.

.rwxr-xr-x 557 xuanwo 24 Mar 18:19 DISCLAIMER
drwxr-xr-x   - xuanwo 29 Mar 11:29 ext
drwxr-xr-x   - xuanwo 29 Mar 11:29 lib
.rwxr-xr-x 60k xuanwo 24 Mar 18:19 LICENSE
drwxr-xr-x   - xuanwo 29 Mar 11:29 licenses
.rwxr-xr-x 90k xuanwo 24 Mar 18:19 NOTICE

[-] No unexpected binary files

apache-hugegraph-incubating-1.3.0 bundles swagger related js & css without 
license details.

I wish this can be addressed in next release.

[x] All source files have ASF headers
[x] Can compile from source on archlinux x86_64

[INFO] Reactor Summary for hugegraph 1.3.0:
[INFO]
[INFO] hugegraph .......................................... SUCCESS [  0.719 s]
[INFO] hugegraph-server ................................... SUCCESS [  0.245 s]
[INFO] hugegraph-core ..................................... SUCCESS [ 44.684 s]
[INFO] hugegraph-api ...................................... SUCCESS [02:35 min]
[INFO] hugegraph-cassandra ................................ SUCCESS [01:18 min]
[INFO] hugegraph-scylladb ................................. SUCCESS [  0.394 s]
[INFO] hugegraph-rocksdb .................................. SUCCESS [  2.545 s]
[INFO] hugegraph-mysql .................................... SUCCESS [  0.327 s]
[INFO] hugegraph-palo ..................................... SUCCESS [  0.320 s]
[INFO] hugegraph-hbase .................................... SUCCESS [ 16.562 s]
[INFO] hugegraph-postgresql ............................... SUCCESS [  1.443 s]
[INFO] hugegraph-dist ..................................... SUCCESS [ 20.348 s]
[INFO] hugegraph-example .................................. SUCCESS [  0.801 s]
[INFO] hugegraph-test ..................................... SUCCESS [ 42.137 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:04 min
[INFO] Finished at: 2024-03-29T11:47:48+08:00
[INFO] ------------------------------------------------------------------------

On Fri, Mar 29, 2024, at 10:17, Jacky Yang wrote:
> Hello Incubator Community,
>
> This is a call for a vote to release Apache HugeGraph(Incubating)
> version 1.3.0-rc1
>
> The Apache HugeGraph community has voted on and approved a proposal to release
> Apache HugeGraph(Incubating) version 1.3.0-rc1
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> HugeGraph community vote thread:
>   • https://lists.apache.org/thread/80t2qqq7tmszm20l7ztosx4fpkhld50l
>
> Vote result thread:
>   • https://lists.apache.org/thread/wymh634mxc0l3y0j7vy9jx1bdw48d5g0
>
> The release candidate:
>   • https://dist.apache.org/repos/dist/dev/incubator/hugegraph/1.3.0
>
> Git tag for the release:
>   • https://github.com/apache/incubator-hugegraph/tree/1.3.0
>
> Git tag & Commit hash for the release:
>   • https://github.com/apache/incubator-hugegraph/tree/release-1.3.0  
> (6a4041e)
>   • https://github.com/apache/incubator-hugegraph-toolchain/tree/release-1.3.0
>      (0dd2339)
>   • https://github.com/apache/incubator-hugegraph-commons/tree/release-1.3.0
>      (c883f56)
>   • https://github.com/apache/incubator-hugegraph-ai/tree/release-1.3.0
> (4f48116)
>
> Keys to verify the Release Candidate:
>   • https://downloads.apache.org/incubator/hugegraph/KEYS
>
> The release GPG user ID: JackyYang (yangji...@apache.org)
>
>
> The vote will be open for at least 72 hours or until necessary number
> of votes are reached.
>
> Please vote accordingly:
>   [ ] +1 approve
>   [ ] +0 no opinion
>   [ ] -1 disapprove with the reason
>
> More detail checklist  please refer:
>   • 
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release,Please refer to:
>   • 
> https://hugegraph.apache.org/docs/contribution-guidelines/validate-release/
> (EN)
>   • 
> https://hugegraph.apache.org/cn/docs/contribution-guidelines/validate-release/
> (CN)
>
>
> Thanks,
> On behalf of Apache HugeGraph(Incubating) community
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org

-- 
Xuanwo

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to