On Wed, 13 Mar 2024 at 16:32, Huajie Wang <benj...@apache.org> wrote:
>
> hi sebb:
>
> The download(https://streampark.apache.org/download) links issue has been
> fixed and the website has been updated . Thanks for your review

Thanks for the very prompt response.

However, there are still some issues: all the links in the archive
section need to use the archive server, not just the artifacts.
[The links will break when the old releases are dropped from downloads.a.o.]

The page uses two different link titles for the signature files:
'Sign' and 'signature'; the latter is clearer.
Also it would be good to use the same order for the links throughout.
Since signature verification is preferred, it should be first i.e (
signature | sha512 )

The page is very clear and easy to use.

>
> Best,
> Huajie Wang
>
>
>
> sebb <seb...@gmail.com> 于2024年3月13日周三 22:50写道:
>
> > Not a blocker for the release per se, but the links for the hashes and
> > sigs on the download page:
> > https://streampark.apache.org/download
> > are wrong.
> > Only the artifacts should use closer.lua; sigs and hashes must link
> > directly to downloads.apache.org,
> > e.g.
> >
> > https://downloads.apache.org/incubator/streampark/2.1.2/apache-streampark-2.1.2-incubating-src.tar.gz.asc
> >
> > Also note that only releases that are still supported should remain on
> > downloads.a.o.
> > Archived releases can be linked from the download page, but should use
> > the ASF archive server at:
> > https://archive.apache.org/dist/incubator/streampark/
> > [Fix the download page links before deleting the old releases!]
> >
> > Is release 2.1.2 archived or current?
> > It's a bit confusing to have it under both sections of the page.
> >
> > Please fix the download page before publishing the new release.
> > Thanks!
> >
> > On Wed, 13 Mar 2024 at 14:38, Jean-Baptiste Onofré <j...@nanthrax.net>
> > wrote:
> > >
> > > +1 (binding)
> > >
> > > I checked:
> > > - incubating in the name
> > > - signature and checksum are good
> > > - ASF header is present
> > > - No unexpected binary files in the source distribution
> > > - LICENSE, NOTICE, DISCLAIMER are there
> > >
> > > NB: are we sure about SECURITY.md file ? Versions in this file look
> > weird.
> > >
> > > Regards
> > > JB
> > >
> > > On Tue, Mar 12, 2024 at 2:45 PM Qingrong wang <monr...@apache.org>
> > wrote:
> > > >
> > > > Hello Incubator Community:
> > > >
> > > > This is a call for a vote to release Apache StreamPark(Incubating)
> > > > version 2.1.3-RC1.
> > > > The Apache StreamPark community has voted on and approved a proposal
> > > > to release Apache StreamPark(Incubating) version 2.1.3-RC1.
> > > > We now kindly request the Incubator PMC members review and vote on
> > > > this incubator release.
> > > > Apache StreamPark, Make stream processing easier! Easy-to-use
> > > > streaming application development framework and operation platform.
> > > >
> > > > StreamPark community vote thread:
> > > > https://lists.apache.org/thread/l4dd4j70wp7rz40fm2nf2o3fwt5x0zr6
> > > >
> > > > Vote result thread:
> > > > https://lists.apache.org/thread/8vd90kxwdvqtkqbtng7jg0mdzscc46xl
> > > >
> > > > The release candidate:
> > > > https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.3-RC1/
> > > >
> > > > Git tag for the release:
> > > > https://github.com/apache/incubator-streampark/releases/tag/v2.1.3-rc1
> > > >
> > > > The artifacts signed with PGP key [40EE71A2], corresponding
> > > > to[monr...@apache.org], that can be found in keys file:
> > > > https://downloads.apache.org/incubator/streampark/KEYS
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > > > number of votes are reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > More detailed checklist please refer:
> > > > •
> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > >
> > > > Steps to validate the release, Please refer to:
> > > > • https://www.apache.org/info/verification.html
> > > > •
> > https://streampark.apache.org/community/release/how_to_verify_release
> > > >
> > > >
> > > > How to Build:
> > > >
> > > > 1) clone source code:
> > > > > git clone -b v2.1.3-rc1 g...@github.com:
> > apache/incubator-streampark.git
> > > >
> > > > 2) build project:
> > > > > cd incubator-streampark && sh ./build.sh
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > On behalf of Apache StreamPark(Incubating) community
> > > >
> > > >
> > > > Best,
> > > > Qingrong Wang
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to