Hi Xuanwo, Thank you for finding these missing license headers, I've opened a PR to address this for our next release. Did you use an automated tool to find these? That would be helpful for evaluating and preparing future release candidates.
Thanks, Riley On 2024/03/11 02:45:50 Xuanwo wrote: > +1 binding > > There are some places to improve in next release, but this release looks good > overall. > > [x] Download links are valid. > [x] Checksums and PGP signatures are valid. > > gpg: Signature made Tue 05 Mar 2024 09:24:47 AM CST > gpg: using RSA key 2E8418801953621FAA322169D6F360887071C194 > gpg: checking the trustdb > gpg: marginals needed: 3 completes needed: 1 trust model: pgp > gpg: depth: 0 valid: 22 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 22u > gpg: next trustdb check due at 2024-05-25 > gpg: Good signature from "skpe...@apache.org <skpe...@apache.org>" [ultimate] > apache-sdap-ingester-1.2.0-incubating-src.tar.gz: OK > gpg: Signature made Tue 05 Mar 2024 09:25:51 AM CST > gpg: using RSA key 2E8418801953621FAA322169D6F360887071C194 > gpg: Good signature from "skpe...@apache.org <skpe...@apache.org>" [ultimate] > apache-sdap-nexus-1.2.0-incubating-src.tar.gz: OK > > [x] Source code distributions have correct names matching the current > release. > [x] LICENSE and NOTICE files are correct. > [-] All files have license headers if necessary. (see below) > [x] No unlicensed compiled archives bundled in source archive. > > In apache-sdap-nexus-1.2.0-incubating-src: > > I found following files without license header. > > .readthedocs.yaml > analysis/static/index.html > analysis/webservice/apidocs/index.html > analysis/webservice/config/scheduler.xml > data-access/.idea/data-access.iml > data-access/.idea/encodings.xml > data-access/.idea/misc.xml > data-access/.idea/modules.xml > data-access/.idea/vcs.xml > data-access/config/schemas/cassandra/nexustiles.cql > data-access/config/schemas/solr/dataset/core.properties > data-access/config/schemas/solr/nexustiles/core.properties > docs/Makefile > docs/granule-download.sh > helm/.helmignore > helm/Chart.yaml > helm/requirements.yaml > helm/templates/_helpers.tpl > helm/templates/collection-manager.yml > helm/templates/collections-config-gitcfg.yml > helm/templates/config-operator-rbac.yml > helm/templates/config-operator.yml > helm/templates/domspurge.yml > helm/templates/gitbasedconfig-crd.yml > helm/templates/granule-ingester.yml > helm/templates/history-pvc.yml > helm/templates/ingress.yml > helm/templates/init-cassandra-configmap.yml > helm/templates/onearth.yml > helm/templates/root-webpage.yml > helm/templates/solr-create-collection.yml > helm/templates/spark-serviceaccount.yml > helm/templates/webapp.yml > helm/values.yaml > integrations/python-client/docs/nexuscli/index.html > integrations/python-client/docs/nexuscli/nexuscli.m.html > integrations/python-client/docs/nexuscli/nexuscli_ow.m.html > integrations/python-client/docs/nexuscli/test/index.html > integrations/python-client/docs/nexuscli/test/nexuscli_test.m.html > > I've found that the following files shouldn't be included, although it's fine > if the community decides otherwise. Just wanted to make sure. > > analysis/.idea/analysis.iml > analysis/.idea/encodings.xml > analysis/.idea/misc.xml > analysis/.idea/modules.xml > analysis/.idea/vcs.xml > > On Sun, Mar 10, 2024, at 09:34, Julian Hyde wrote: > > Forwarding my vote from the dev@ list: > > > > +1 (binding) > > > > The points made by Sebb and PJ seem valid but they do not affect this vote. > > > > Julian > > > > On Fri, Mar 8, 2024 at 2:25 PM sebb <seb...@gmail.com> wrote: > >> > >> On Fri, 8 Mar 2024 at 22:17, PJ Fanning <fannin...@gmail.com> wrote: > >> > > >> > Hi Stepheny, > >> > > >> > Can you remove the old RCs from > >> > https://dist.apache.org/repos/dist/dev/incubator/sdap/ ? > >> > > >> > Is the signing key in > >> > https://dist.apache.org/repos/dist/release/incubator/sdap/KEYS ? With > >> > releases, you are supposed to point users to this file not provide a > >> > link to https://keyserver.ubuntu.com > >> > >> The KEYS file must be linked from > >> > >> https://downloads.apache.org/incubator/sdap/KEYS > >> > >> The dist.apache.org host is for staging the files, not for general > >> publication. > >> > >> > >> > On Fri, 8 Mar 2024 at 18:55, Stepheny Perez <skpe...@apache.org> wrote: > >> > > > >> > > Hello everyone, > >> > > > >> > > This is a call for a vote to release Apache SDAP (incubating) version > >> > > 1.2.0-rc4. > >> > > > >> > > The Apache SDAP community has voted to approve release of Apache SDAP > >> > > (incubating) version 1.2.0-rc4. > >> > > > >> > > We now request the Incubator PMC review and vote on this release. > >> > > > >> > > SDAP community thread: > >> > > https://lists.apache.org/thread/h9g3cdok0py2vjp1pplz1wq4ofl4sbjx > >> > > > >> > > Changes made between previous candidate (rc3) and this one (rc4) are > >> > > as follows: > >> > > - Updated SDAP to use Poetry package manager to more explicitly manage > >> > > dependencies and transitive dependencies. This was needed to ensure no > >> > > GPL license dependencies are used by the software. > >> > > - Patch for domspurge helper script > >> > > > >> > > Instructions for building docker images from source can be found here: > >> > > https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc4/docs/build.rst > >> > > Instructions for deploying locally to test can be found here: > >> > > https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc4/docs/quickstart.rst > >> > > The release files, including signatures, digests, etc. can be found at: > >> > > https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.2.0-rc4/ > >> > > > >> > > For convenience, the tags we built the release artifacts to be voted on > >> > > from are 1.2.0-rc4: > >> > > > >> > > - ingester: > >> > > - URL: https://github.com/apache/incubator-sdap-ingester/tree/1.2.0-rc4 > >> > > - Commit: 5c116badfaf913734d017d41acc765ed3fd978a1 > >> > > > >> > > - nexus: > >> > > - URL: https://github.com/apache/incubator-sdap-nexus/tree/1.2.0-rc4 > >> > > - Commit: 3fce31f08b9057db446036724e8bc62dd6d1560a > >> > > > >> > > For verification, the hashes (SHA-512) of the .tar.gz artifacts we are > >> > > voting on are as follows: > >> > > > >> > > apache-sdap-ingester-1.2.0-incubating-src.tar.gz: > >> > > 7301c54e765882c45f6efe4a06463b837ace62b6eea2ae5437113357466e52f1d905c3c9d46295f1b1058b9ecf5025942f8a89b2c53a1b0d6b69cd52a8890257 > >> > > > >> > > apache-sdap-nexus-1.2.0-incubating-src.tar.gz: > >> > > 1a2907f9c36dbf0b4b25d54c095303ab0602fa9e0a9423deceae402ffd9a360e21ba832c3ea497d8eccbc6c91fedd2926b3b33181a14c22d50d0ec996282bc75 > >> > > > >> > > Release artifacts are signed with the following key: > >> > > https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2E8418801953621FAA322169D6F360887071C194 > >> > > > >> > > Please vote on releasing this package as Apache SDAP (incubating) > >> > > 1.2.0. > >> > > > >> > > The vote is open for 72 hours and passes if at least 3 +1 PMC votes > >> > > are cast. > >> > > > >> > > [ ] +1 Release this package as Apache SDAP (incubating) 1.2.0 > >> > > [ ] +0 No opinion > >> > > [ ] -1 Do not release this package because ... > >> > > > >> > > Thank you, > >> > > Stepheny > >> > > > >> > > --------------------------------------------------------------------- > >> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> > > For additional commands, e-mail: general-h...@incubator.apache.org > >> > > > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> > For additional commands, e-mail: general-h...@incubator.apache.org > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > -- > Xuanwo > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
