-1 (binding) - Checked the diff between 0.3.2 and 0.4.0-rc4: FAILED ( https://github.com/apache/incubator-celeborn/compare/v0.3.2-incubating...v0.4.0-incubating-rc4). Problems observed include: * The client-flink/flink-1.15-shaded module bundles *com.google.guava:failureaccess* but has no entry in the embedded LICENSE file. Actually, most (if not all) shaded jars (flink-1.14/1.15/1.17/1.18-shaded, spark-3-shaded, mr-shaded, etc.) have this problem. * The client-mr/mr-shaded module bundles *com.github.luben:zstd-jni* but has no entry in the embedded LICENSE file. What's more, since this bundled dependency is with BSD license [1], the relative license file needs to be embedded.
AFAICS, this release has multiple dependency-related (dep version change, new dep introduced, etc.) commits, so I suggest paying more attention to the legal check for the next RC. And maybe a shorter release cycle for major versions would help to reduce the efforts required for (incremental) legal checking. Best Regards, Yu [1] https://github.com/luben/zstd-jni?tab=License-1-ov-file#readme On Tue, 23 Jan 2024 at 15:20, Suyan <suyanh...@gmail.com> wrote: > I was just kidding. Don't worry about it. > It's certainly not a problem. > > Sincerely, > Suyan > > > 2024年1月23日 01:49，Fu Chen <cfmcgr...@gmail.com> 写道： > > > > Hi Suyan, > > > > Thank you for your vote. The GPG key was generated when I first released > > the Kyuubi project. Regarding the GPG key name, it's merely an > identifier, > > and I believe it should not be a blocking issue. > > > > Thanks, > > Fu Chen > > > > Suyan <suyanh...@apache.org> 于2024年1月22日周一 22:01写道： > > > >> +1 non-binding > >> > >> [x] Download links are valid > >> [x] Checksums and signatures > >> gpg: assuming signed data in > >> './apache-celeborn-0.4.0-incubating-source.tgz' > >> gpg: Signature made 四 1/18 21:06:45 2024 CST > >> gpg: using RSA key > 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B > >> gpg: checking the trustdb > >> gpg: marginals needed: 3 completes needed: 1 trust model: pgp > >> gpg: depth: 0 valid: 12 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 12u > >> gpg: next trustdb check due at 2024-05-25 > >> gpg: Good signature from "Fu Chen (For Kyuubi release) > >> <fc...@apache.org>" [ultimate] > >> > >> [x] LICENSE/NOTICE files exist > >> [x] NO unexpected binary files > >> [x] Source files have ASF headers > >> [x] Can compile from source > >> > >> Build successed on Apple Silicon M1(arm64). > >> > >> > >> I noticed the release manager's key name 'Fu Chen (for Kyuubi > >> release)', maybe a different name would be better? lol > >> > >> Sincerely, > >> Suyan > >> > >> Fu Chen <fc...@apache.org> 于2024年1月22日周一 00:25写道： > >>> > >>> Hi IPMC, > >>> > >>> This is a call for a vote to release Apache Celeborn (Incubating) > >>> 0.4.0-incubating-rc4 > >>> > >>> The Apache Celeborn community has voted on and approved a proposal to > >>> release Apache Celeborn (Incubating) version 0.4.0-incubating-rc4. > >>> We now kindly request the Incubator PMC members review and vote on this > >>> incubator release. > >>> > >>> celeborn@dev vote thread: > >>> > >>> https://lists.apache.org/thread/w91n2vgwts06gskoc5y19gl49myjm1jq > >>> > >>> celeborn@dev vote result thread: > >>> > >>> https://lists.apache.org/thread/7ylzdq6htzvlnnjzb5lhdd1nsfv4cjmn > >>> > >>> The git tag to be voted upon: > >>> > >>> > >> > https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4 > >>> > >>> The git commit hash: > >>> 8bc07466dd85a90216820617015e329fb806c7dd > >>> > >>> The source and binary artifacts can be found at: > >>> > >>> > >> > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4 > >>> > >>> The staging repo: > >>> > >>> > >> > https://repository.apache.org/content/repositories/orgapacheceleborn-1051 > >>> > >>> Fingerprint of the PGP key release artifacts are signed with: > >>> 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B > >>> > >>> My public key to verify signatures can be found in: > >>> > >>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS > >>> > >>> The vote will be open for at least 72 hours or until the necessary > >>> > >>> number of votes are reached. > >>> > >>> Please vote accordingly: > >>> > >>> [ ] +1 approve > >>> [ ] +0 no opinion > >>> [ ] -1 disapprove (and the reason) > >>> > >>> Checklist for release: > >>> > >>> > >> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > >>> > >>> Steps to validate the release: > >>> > >>> https://www.apache.org/info/verification.html > >>> > >>> Please be aware that there has been a transition in the Celeborn > >> project's > >>> build tool, shifting from Maven to SBT. The SBT build documentation is > >>> available at https://celeborn.apache.org/docs/latest/developers/sbt/. > >>> > >>> For illustrative purposes: > >>> > >>> Packaging the project > >>> ``` > >>> ./build/sbt clean package > >>> ``` > >>> > >>> Creating the distribution > >>> ``` > >>> ./build/make-distribution.sh --sbt-enabled --release > >>> ``` > >>> > >>> Regards, > >>> Fu Chen > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
