+1 binding + Download links valid + Checksum and signature matched + LICENSE and NOTICE present + DISCLAIMER present + Can compile from source
Best, tison. Christofer Dutz <christofer.d...@c-ware.de> 于2024年1月5日周五 23:39写道： > > Oh sorry for the late reply … I must have missed these … sorry, > > But I agree with Wilfried … for me these files are just as in other projects > a maven pom. > A manual decision of the project to what goes in the project. Therefore would > I also think a header is appropriate. In PLC4Go we have it exactly that way: > the go.mod has a header and the go.sum doesn’t (It’s actually not even > checked in … I think) > > Chris > > > Von: tison <wander4...@gmail.com> > Datum: Mittwoch, 3. Januar 2024 um 10:33 > An: general@incubator.apache.org <general@incubator.apache.org> > Betreff: Re: [VOTE] Release Apache Answer(Incubating) v1.2.1-RC1 (Round2) > > I would agree with adding a header. > > Yep it's easily to add one, like what Fury did [1]. > > > It is maintained mostly by hand > > ... while I generally just run `go mod tidy` and `go get` to let it > generate the necessary go.mod. > > Best, > tison. > > [1] https://github.com/apache/incubator-fury/blob/main/go/fury/go.mod > > Wilfred Spiegelenburg <wilfr...@apache.org> 于2024年1月3日周三 17:29写道： > > > > On 2024/01/03 08:24:10 tison wrote: > > > > go.mod could have an apache header > > > > > > go.mod doesn't seems something creative but a bookkeeping index. I > > > wonder if we should add license header for such files. > > > > go.mod is part of the project and lists the import and versions. It is > > maintained mostly by hand, partially via tools (layout and indirect ref > > etc), I would agree with adding a header. > > go.sum on the other hand is maintained by tools only based on the go.mod > > content. No header in that file as it causes issues, > > > > Wilfred > > > > > > > > Best, > > > tison. > > > > > > Christofer Dutz <christofer.d...@c-ware.de> 于2024年1月3日周三 16:19写道： > > > > > > > > +1 (binding) > > > > > > > > However, I did find, that it seems to be impossible to build from > > > > sources, if the sources are unpacked from the src-archive instead of > > > > checked out. This should be addressed in future releases. > > > > > > > > Chris > > > > > > > > [OK] Download all staged artifacts under the url specified in the > > > > release vote email. > > > > [OK] Verify the signature is correct. > > > > [OK] Check if the signature references an Apache email address. > > > > [OK] Verify the SHA512 hashes. > > > > [OK] Unzip the archive. > > > > [OK] Verify the artifacts have “apache” and “incubating” in their names > > > > [OK] Verify the existence of LICENSE, NOTICE, README, DISCLAIMER files > > > > in the extracted source bundle. > > > > [OK] Verify the content of LICENSE, NOTICE, README, DISCLAIMER files in > > > > the extracted source bundle. > > > > > > > > * Using non-WIP disclaimer, doing the thorough checks. > > > > * NOTICE contains 2023, but as the RC was created 2023, no issue > > > > [OK] Run RAT externally to ensure there are no surprises. > > > > > > > > * go.mod could have an apache header > > > > * docs/img/logo.svg could have an apache header > > > > * ui/src/assets/images/default-avatar.svg could have an apache > > > > header > > > > [OK] Search for SNAPSHOT references > > > > [OK] Search for Copyright references, and if they are in headers, make > > > > sure these files containing them are mentioned in the LICENSE file. > > > > [MINOR] Build the project according to the information in the README.md > > > > file. > > > > > > > > * Readme could use an addition to add mockgen to the prerequisites > > > > * When building the second part “make build” I’m getting a fatal > > > > error: > > > > * “fatal: not a git repository (or any of the parent > > > > directories): .git” > > > > > > > > > > > > Von: Justin Mclean <jus...@classsoftware.com> > > > > Datum: Mittwoch, 27. Dezember 2023 um 06:26 > > > > An: incubator general apache <general@incubator.apache.org> > > > > Betreff: Re: [VOTE] Release Apache Answer(Incubating) v1.2.1-RC1 > > > > (Round2) > > > > Hi, > > > > > > > > +1 (binding) > > > > > > > > In the source release, I checked: > > > > - incubating in artifacts name > > > > - signatures and hashes are correct > > > > - LICENSE and NOTICE are fine > > > > - DISCLAIMER exists > > > > - all files have ASF headers > > > > - no unexpected binary files > > > > - my system isn't setup to compile it > > > > > > > > In the REDME.md it suggests that people run the latest non-released > > > > version; please don't do this. [1] > > > > > > > > Kind Regards, > > > > Justin > > > > > > > > 1. https://www.apache.org/legal/release-policy.html#what > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
