I'll have a look around to see if there are other issues. With the BSD license mentioned in the client-spark/spark-3-shaded LICENSE, could it be adjusted to say which libs it applies to?
https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/src/main/resources/META-INF/LICENSE On Tue, 19 Sept 2023 at 12:18, Cheng Pan <pan3...@gmail.com> wrote: > > Hi PJ Fanning, > > Thanks for pointing out this issue, it was considered but seems broken > recently, unfortunately. > > The proposed NOTICE and LICENSE files are under [1], would you mind taking a > look? If it's OK, I’m going to investigate and fix the packaging issue then. > > Given it’s a license issue, I suppose this RC has failed, but it would be > nice if you could help to check if other things are OK before starting the > next RC. > > [1] > https://github.com/apache/incubator-celeborn/tree/main/client-spark/spark-3-shaded/src/main/resources/META-INF > > Thanks, > Cheng Pan > > > > On Sep 19, 2023, at 18:38, PJ Fanning <fannin...@apache.org> wrote: > > > > I have some concerns over the jars that are part of the release. > > > > I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in > > > > https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/ > > > > The jar has separate META-INF LICENSE and LICENSE.txt. Likewise for > > NOTICE and NOTICE.txt. > > > > The NOTICE.txt seems to be from Commons Lang. > > > > The jar contains classes from other projects (including non-ASF > > projects like guava) but there appears to be no acknowledgement of > > this in the META-INF LICENSE/NOTICE files. > > > > Example file: > > org/apache/celeborn/shaded/com/google/common/base/Ascii.class > > > > I checked celeborn-client-flink-1.17-shaded_2.12-0.3.1-incubating.jar > > and it has similar issues. > > > > Could you fix it so that these celeborn jars have only one LICENSE and > > NOTICE file and the LICENSE and NOTICE should acknowledge all the > > non-Celeborn classes that are bundled? > > > > I'd be interested in other people's interpretation here but I think > > the licensing in the jars is not correct. > > > > > > > > On Fri, 15 Sept 2023 at 05:03, Cheng Pan <pan3...@gmail.com> wrote: > >> > >> Hi IPMC, > >> > >> This is a call for a vote to release Apache Celeborn (Incubating) > >> 0.3.1-incubating-rc2 > >> > >> The Apache Celeborn community has voted on and approved a proposal to > >> release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2. > >> We now kindly request the Incubator PMC members review and vote on this > >> incubator release. > >> > >> celeborn@dev vote thread: > >> https://lists.apache.org/thread/8bbnpxy6kyn7wxvjwmz2c8vn7bcw67cv > >> > >> celeborn@dev vote result thread: > >> https://lists.apache.org/thread/xg38xd2j4y434552z3cbgtntfp9kp1l9 > >> > >> The git tag to be voted upon: > >> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.1-incubating-rc2 > >> > >> The git commit hash: > >> 7ec5596748af49ef9cb429d08550e89d94d5cc74 > >> > >> The source and binary artifacts can be found at: > >> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.1-incubating-rc2 > >> > >> The staging repo: > >> https://repository.apache.org/content/repositories/orgapacheceleborn-1039 > >> > >> Fingerprint of the PGP key release artifacts are signed with: > >> 8FC8075E1FDC303276C676EE8001952629BCC75D > >> > >> My public key to verify signatures can be found in: > >> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS > >> > >> The vote will be open for at least 72 hours or until the necessary > >> number of votes are reached. > >> > >> Please vote accordingly: > >> > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove (and the reason) > >> > >> Checklist for release: > >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > >> > >> Steps to validate the release: > >> https://www.apache.org/info/verification.html > >> > >> Instructions for making binary artifacts from source: > >> build/make-distribution.sh --release > >> > >> Thanks, > >> Cheng Pan > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
