Sorry guys, but I found a critical issue thus another -1 (binding)

* The source package contains a licenses-binary directory, which has
un-included dependency licenses (for source). Please check the packaging
script and confirm whether there is any error in it (the name of "licenses-
*binary*" indicates something wrong, which causes my attention)

Best Regards,
Yu


On Thu, 9 Feb 2023 at 18:43, angers zhu <angers....@gmail.com> wrote:

> +1 (no-binding)
>
> Checked:
>
> [1] ./build/make-distribution.sh -Pspark-3.1 (macOs Catalina 10.15.7)
> [2] RELEASE file are correct
> [3] jar soft link looks good
> [4] "incubating" in celeborn jar name
> [5] checksums are good
> [6] signatures are good.
>
> Kent Yao <y...@apache.org> 于2023年2月8日周三 15:07写道:
>
> > +1 nonbinding
> >
> > - downloads ok
> > - All source files have license headers
> > - no binary files in the source release
> > - sig/checksums are ok
> > - notice/disclaimer/license files are good
> > - build from source successfully
> >
> > Kent Yao
> >
> > On 2023/02/08 02:40:34 Cheng Pan wrote:
> > >  +1 (no-binding)
> > >
> > > I checked
> > >
> > > - links are valid.
> > > - "incubating" is in the name.
> > > - LICENSE looks good.
> > > - NOTICE looks good.
> > > - DISCLAIMER exists.
> > >
> > > - signatures are good.
> > > ```
> > > gpg --verify apache-celeborn-0.2.0-incubating-source.tgz.asc
> > > gpg --verify apache-celeborn-0.2.0-incubating-bin.tgz.asc
> > > ```
> > >
> > > - checksums are good.
> > > ```
> > > sha512sum --check apache-celeborn-0.2.0-incubating-bin.tgz.sha512
> > > sha512sum --check apache-celeborn-0.2.0-incubating-source.tgz.sha512
> > > ```
> > >
> > > - build success from source code (openjdk-8, ubuntu 22.04 x86).
> > > ```
> > > build/make-distribution.sh --release
> > > ```
> > >
> > > Thanks,
> > > Cheng Pan
> > >
> > >
> > > On Feb 8, 2023 at 10:37:32, Ethan Feng <ethanf...@apache.org> wrote:
> > >
> > > > Hello Incubator Community,
> > > >
> > > > This is a call for a vote to release Apache Celeborn(Incubating)
> > > > version 0.2.0-incubating-rc4
> > > >
> > > > The Apache Celeborn community has voted on and approved a proposal to
> > > > release
> > > > Apache Celeborn(Incubating) version 0.2.0-incubating-rc4
> > > >
> > > > We now kindly request the Incubator PMC members review and vote on
> this
> > > > incubator release.
> > > >
> > > > Celeborn community vote thread:
> > > > • https://lists.apache.org/thread/3qv3byyy1rqv7l9qsx02gbto1n9ymd1h
> > > >
> > > > Vote result thread:
> > > > • https://lists.apache.org/thread/k4jvqdd0dwk9dc7t6n80tgqv99fmwok7
> > > >
> > > > The release candidate:
> > > > •
> > > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc4
> > > >
> > > > Git tag for the release:
> > > > •
> > > >
> >
> https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc4
> > > >
> > > > Public keys file:
> > > > • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> > > >
> > > > The change log is available in:
> > > > •
> > > >
> >
> https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc4
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > number
> > > > of votes are reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > More detailed checklist please refer:
> > > > •
> > > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > >
> > > > Steps to validate the release, Please refer to:
> > > > • https://www.apache.org/info/verification.html
> > > >
> > > > Thanks,
> > > > On behalf of Apache Celeborn(Incubating) community
> > > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>

Reply via email to