Hi Justin, Thanks for the quick reply.
*bq. Not sure why you are discussing this on your private list* Since I'm not sure whether the team has already addressed the issue and prepared another RC, and I'm not sure whether my understanding is correct, so I reduce the discussion scope to internal to prevent bothering others. Now I'm adding back the @general list since the discussion might also help others. *bq. It belongs in LICENSE not NOTICE only copyright notices that have been removed (by or with the permission of the owner) get listed in NOTICE* Since Guava is also with ALv2, referring to [1], my understanding is that: 1. There should be no copyright notice in the header (#2) 2. We need to move the copyright to the NOTICE file associated with each applicable project release (#1.b) And referring to [2], "Copyright notifications which have been relocated, rather than removed, from source files must be preserved in NOTICE (unless embedded in MIT/BSD license)". I'm not sure whether reserving the copyright in Spark way means "relocate", but if it is, then it seems the copyright should occur (be reserved) in NOTICE. Please further correct me if I misunderstood anything. Thanks. Best Regards, Yu [1] https://www.apache.org/legal/src-headers.html#headers [2] https://infra.apache.org/licensing-howto.html#mod-notice On Tue, 31 Jan 2023 at 11:51, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Not sure why you are discussing this on your private list. > > 3. The Spark project directly nests the Guava copyright in the source > file, which is incorrect according to [1] from my perspective. Instead, it > should include the Guava copyright in its NOTICE file. > > > It belongs in LICENSE not NOTICE only copyright notices that have been > removed (by or with the permission of the owner) get listed in NOTICE. > > > 4. For us, I believe the correct thing to do is to add the Guava copyright > into our NOTICE file, in a way like below (referring to [4]): > The codes of common/network/util/LimitedInputStream partially derives > from Guava > Copyright (C) 2007 The Guava Authors > > > No that is not correct. > > Kind Regards, > Justin > > On 31 Jan 2023, at 2:36 pm, Yu Li <car...@gmail.com> wrote: > > Hi Team, > > I'm wondering whether this issue is already addressed, if not, here are my > two cents: > 1. Overall we should follow the instructions here: [1]. > 2. From the originated Spark source file [2], it stems from the Google > Guava project [3]. > 3. The Spark project directly nests the Guava copyright in the source > file, which is incorrect according to [1] from my perspective. Instead, it > should include the Guava copyright in its NOTICE file. > 4. For us, I believe the correct thing to do is to add the Guava copyright > into our NOTICE file, in a way like below (referring to [4]): > The codes of common/network/util/LimitedInputStream partially derives > from Guava > Copyright (C) 2007 The Guava Authors > 5. The Spark modified part (if any, didn't check details) should already > be covered by the existing notice in NOTICE file > This product includes software developed at > The Apache Software Foundation (https://www.apache.org/). > > @Mentors: > Feel free to correct me if you have different ideas > > CC @Justin here for easier follow-up (and thanks for the careful review, > Justin!) > > Best Regards, > Yu > > [1] https://www.apache.org/legal/src-headers.html#headers > [2] > https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java > [3] > https://github.com/google/guava/blob/master/guava/src/com/google/common/io/ByteStreams.java#L706 > [4] https://infra.apache.org/licensing-howto.html#example-notice > > > ---------- Forwarded message --------- > From: Ethan Feng <ethanf...@apache.org> > Date: Sat, 28 Jan 2023 at 10:39 > Subject: Re: [VOTE] Release Apache Celeborn(Incubating) > 0.2.0-incubating-rc3 > To: <general@incubator.apache.org> > > > Hi Justin, > Thanks for your advice. We'll consult our mentors. > > This vote is closed. > > Thanks, > Ethan Feng > > Justin Mclean <jus...@classsoftware.com> 于2023年1月26日周四 06:29写道： > > > > Hi, > > > > I suggest you ask you mentors for help on this. > > > > > Thanks for your advice. We’ve checked the spark distribution > > > package, and we figure out that there is no [3] related notice in > > > [1][2]. > > > > You still need to take the relevant parts from that NOTICE file and add > it to yours. Please see [1] and [2]. This IMO would include the "Apache > Spark Copyright 2014 and onwards The Apache Software Foundation.” part. > > > > > Do we need to add the following text block to notice file in our > > > source package according to [4]? > > > > > > > “./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java > > > is based on LimitedInputStream.java from Google Guava > > > Copyright (C) 2007 The Guava Authors” > > > > No license information goes in LICENSE not NOTICE, and the Google Guava > file doesn’t have a NOTICE file that I can see. > > > > Kind Regards, > > Justin > > > > 1. https://infra.apache.org/licensing-howto.html#alv2-dep > > 2. https://infra.apache.org/licensing-howto.html#mod-notice > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > >
