Thanks for review and feedback, streampark project does included the source code of the maven-wrapper project, We will add the license information of maven-wrapper to LICENSE file.
Best, Huajie Wang kezhenxu94 <kezhenx...@apache.org> 于2023年1月28日周六 22:15写道： > > > On Jan 28, 2023, at 21:43, Justin Mclean <jus...@classsoftware.com> > wrote: > > > > Hi, > > > >> 2. NOTICE is OK but I’m not sure if the maven wrapper code is included > in > >> the source release? > >> > >> the maven wrapper code is not included in the source code[1] > > But I can see the maven wrapper scripts are included in the source tar > ball. > > ```shell > ~ % tar -tf > /Users/kezhenxu94/Downloads/apache-streampark-2.0.0-incubating-src.tar.gz > | grep mvnw > apache-streampark-2.0.0-incubating-src/mvnw > apache-streampark-2.0.0-incubating-src/mvnw.cmd > > apache-streampark-2.0.0-incubating-src/streampark-console/streampark-console-service/src/main/assembly/bin/mvnw > > apache-streampark-2.0.0-incubating-src/streampark-console/streampark-console-service/src/main/assembly/bin/mvnw.cmd > > ``` > > > > Thanks for your feedback, it is really redundant to mention in the > NOTICE file, We will fix it. > > So I think you want to add the license information to LICENSE file, > instead of removing them from NOTICE file. > > > > > Kind Regards, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
