Hi Paul, Thanks for your check and vote. Welcome to submit PR. The copyright notice has been incorrect modified by this commit, I will fix this.
Yes, we need to add a step to remove the wrapper-related file in our build file. Thanks, Wenjun On Wed, Jun 29, 2022 at 10:57 PM Paul King <pa...@asert.com.au> wrote: > > Yes, the build file is using (just a little) Groovy 3 syntax (new in > Gradle 7). You could revert to older style syntax but it would > probably be better to have a bootstrap step that downloaded the gradle > wrapper and then use the wrapper in all of your instructions. The > Groovy build has such a setup. Let me know if you need a PR (for the > English instructions anyway). You could then use older Gradle versions > to bootstrap and then gradlew from then on. It would be considered > better practice in terms of reproducible builds. > > I noticed also that you seem to have "gradlew.bat" in your source zip. > Is that an oversight? I couldn't see where you removed other gradle > wrapper-related artifacts in your build file - though there doesn't > seem to be any others which is usual practice currently. > > Also, it seems this commit splattered over the copyright notice lines > from the gradle supplied gradlew/gradlew.bat files in the main source > repo: > https://github.com/apache/incubator-eventmesh/commit/032bb0d8b09 > I didn't check if any other files are splattered in the same way in > other commits but it might be worthwhile to do a bit of an audit. > > +1 (binding) but only because of the WIP disclaimer (because of the > issue mentioned above) > > I checked: > - incubating in name > - signatures and hashes okay > - disclaimer exists (WIP) > - LICENSE and NOTICE seem okay > - no unexpected binary files (but I suspect gradlew.bat is an oversight) > - headers seem okay apart from gradlew.bat which shouldn't be there I suspect. > > > Cheers, Paul. > > > On Wed, Jun 29, 2022 at 7:35 PM wenjun <wen...@apache.org> wrote: > > > > Hi Justin, > > > > Thanks for your check, vote, and suggestion, the build error may due > > to an incompatible version of gradle, the gradle version may need to > > be higher than 7. > > > > And I will add the build step to README soon, and modify the download > > way in EventMesh doc to use ASF release rather than github. > > > > > > Thanks, > > Wenjun > > > > On Wed, Jun 29, 2022 at 1:31 PM Justin Mclean <jus...@classsoftware.com> > > wrote: > > > > > > Hi, > > > > > > +1 (binding) if it can be built from the source release. > > > > > > I checked: > > > - incubating in name > > > - signatures and hashes are fine > > > - disclaimer exists (WIP) > > > - LICENSE and NOTICE seem fine > > > - no unexpected binary files > > > - ASF files have ASF headers > > > - Was unable to compile from source > > > > > > Can someone confirm you can build this from the source release? I’m > > > getting an error in the gradle build file, but it may just be my setup. > > > > > > Error is: > > > Could not compile build file > > > '/Users/justinmclean/ApacheEventMesh/apache-eventmesh-1.5.0-incubating-src/build.gradle'. > > > > startup failed: > > > build file > > > '/Users/justinmclean/ApacheEventMesh/apache-eventmesh-1.5.0-incubating-src/build.gradle': > > > 116: unexpected token: ) @ line 116, column 105. > > > dist/lib").list()).orElseGet(() -> new S > > > > > > It would also be nice to include instructions on how to build in the > > > README. On the page here [1] it states "Download and extract the source > > > code of the latest release from GitHub releases.”. Please do not > > > recommend this, please recommend instead that people use the offical ASF > > > releases. > > > > > > Kind Regards, > > > Justin > > > > > > 1. > > > https://github.com/apache/incubator-eventmesh/blob/master/docs/en/installation/01-runtime.md > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
