+1 from me: Checked: - incubating in name - both of Signatures/hashes are good - LICENSE/NOTICE good - No unexpected binary files - Checked all source files have ASF headers - Compilable from source
-Wangda On Sun, Aug 8, 2021 at 11:18 PM Xun Liu <liu...@apache.org> wrote: > hi Weiwei Yang > > Thank you for your prompt reply. > +1 (non-binding) from me. > > Best regards > Xun Liu > > On Mon, Aug 9, 2021 at 1:51 PM Weiwei Yang <w...@apache.org> wrote: > > > hi Xun, Justin > > > > Thanks for the suggestion! > > I have created https://issues.apache.org/jira/browse/YUNIKORN-789 to > > address this. > > > > On Sun, Aug 8, 2021 at 10:48 PM Justin Mclean <jus...@classsoftware.com> > > wrote: > > > > > Hi, > > > > > > > I have a question. > > > > I did not see the two files `NOTICE` and `DISCLAIMER` in the > > > > [1],[2],[3],[4] repo of incubator-yunikorn. > > > > > > It would be good if they are there, but what matters is if they end up > in > > > the release artefacts. > > > > > > Thanks, > > > Justin > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > >
