Just a final note on the "foreign code" problem. It's literally impossible to now simply include anything from the original source code. The codebase and API of Apace Hop have drifted so far away from where we once were that for new feature requests (like for example the recent addition of Parquet File Input/Ouput transforms) it's simply useless to even look at any existing code. It's just faster to write new functionality, also because the API is much simpler and cleaner now. The Simple SQL Parser that was included recently and where we had the one file with incorrect header was included for completeness sake but it was the notable exception I think. But even that code needed refactoring, cleanup and actually quite a bit of work to port over. I'd be happy to throw that code back out if anyone feels it's needed. In this discussion I just haven't seen a real reason for it though. I guess I just don't understand the issue.
On Mon, Jun 14, 2021 at 8:44 AM Hans Van Akelyen <hans.van.akel...@gmail.com> wrote: > Hi, > > The vote has ended, thank you all for the feedback. > > As you pointed out, were it only the header issue in hpl/hwf it would have > been an option, the foreign code is a bigger problem. > I will go back to the dev list to discuss creating rc2. > > Cheers, > Hans > > On Mon, 14 Jun 2021 at 02:02, Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > I suggest you discuss this with you mentors and together come up with the > > best approach. > > > > There's a higher bar for release without the work in progress disclaimer. > > I had noticed the issue in a previous release but I didn’t say anything > > about it on the assumption that it wold be corrected once the WIP > > disclaimer was gone, apologies for that. > > > > Also I’d like to point out that my -1 vote is not a veto, a release only > > needs 3 +1 votes and more +1 votes than -1 votes. As the vote currently > > stands, the release manager can decide if the license and header issues > are > > serious enough to not release this. I would be more concerned abut the > > files that have incorrect ASF headers and clarifying the license of those > > files than the missing headers. > > > > Kind Regards, > > Justin > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
