Hi, +1 from me.
I checked: - DISCLAIMER-WIP exists - NOTICE is fine - Checked PGP signatures - Checked checksums - Code compiles PS: Files without ASF headers should be fixed. Kind Regards, Furkan KAMACI On Tue, Jun 8, 2021 at 9:34 AM Xun Liu <liu...@apache.org> wrote: > Hi, > > I have checked the following items: > - Incubating in name > - NOTICE is fine > - DISCLAIMER exists > - All links are valid > - No unexpected binary files > > But I found below these ASF files didn't have ASF headers, > > https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/master/Dockerfile > > https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/master/aarch64-unknown-optee-trustzone.json > > https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/master/arm-unknown-optee-trustzone.json > There may be other missing files, Please check it again, Thanks. :-) > > Best regards > Xun Liu > > > On Tue, Jun 8, 2021 at 11:45 AM Gang(Gary) Wang <ga...@apache.org> wrote: > > > +1 binding. > > Thanks. > > > > On Mon, Jun 7, 2021 at 8:42 PM Zhaofeng Chen <z...@apache.org> wrote: > > > > > +1. > > > > > > I checked > > > - Signatures and hashes are good. > > > - Sources compiled successfully according to the doc. > > > - All test cases are passed. > > > > > > Best, > > > Zhaofeng > > > > > > On Mon, Jun 7, 2021 at 8:16 PM Justin Mclean <jus...@classsoftware.com > > > > > wrote: > > > > > > > Hi, > > > > > > > > +1 binding, but only due to WIP disclaimer. The license issue, file > > > header > > > > and binary files issues will need to be fixed at some point. > > > > > > > > I also note that this release contains code under the GPL license, > > which > > > > is not compatible with the Apache license and cannot be included in > an > > > ASF > > > > source release. It would be good to note this in your disclaimer so > > that > > > > users of this software are aware of this issue. Hopefully the PPMC is > > > aware > > > > of this issue and has a plan to remove or replace this software with > > > > something that has a compatible license. > > > > > > > > I checked: > > > > - Incubating in name > > > > - signatures and hashes are fine > > > > - WIP DISCLAIMER exists > > > > - LICENSE needs more work > > > > - NOTICE is fine > > > > - There are unexpected binary files in the source release > > > > - There a large number of source files without ASF header so it is > not > > > > easy to tell if files have the right headers or not > > > > - didn’t compile from source > > > > > > > > Thanks. > > > > Justin > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > >
