Hi, +1 (binding)
I checked: - incubating in name - signatures and hashes are fine (you might want to consider unsing sha 512) - DISCLAIMER exists - LICENSE is fine - year in NOTICE is incorrect, please fix (this is also incorrect in the README.md) - files have ASF headers - no unexpected binary files - can compile from source It would be nice to mention the minimum java requirements in the README. I would take care when including anything from stack overflow as code there is not compatible with the Apache license. [1] Thanks, Justin 1. https://www.apache.org/legal/resolved.html#stackoverflow --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
