OK. I will check and fix the license header In next release, this thar OK ?
kezhenxu94@apache <kezhenx...@apache.org> 于2021年4月12日周一 上午10:25写道：
>
> > On Apr 12, 2021, at 09:33, 寒江雪 <yangz...@gmail.com> wrote:
> >
> > Hi Zhenxu Ke:
> > Thanks for voting. The following files are not from 3rd-party, they are
> > written by ourselves:
> > 1. be/src/olap/rowset/alpha_rowset_writer.h
> > 2. be/src/olap/rowset/segment_v2/empty_segment_iterator.cpp
>
> If that’s the case, the license header in file
> be/src/olap/rowset/segment_v2/empty_segment_iterator.cpp is not complete,
> please check and compare with other files, add the missing lines into it.
>
> > I will fix the wrong path of
> > "fe/fe-common/src/main/java/org/apache/doris/common/jmockit" in
> LICENSE.txt
> >
> > kezhenxu94@apache <kezhenx...@apache.org> 于2021年4月11日周日 下午9:47写道：
> >
> >> Hi, I’m +1, here are my check list
> >>
> >> - LICENSE, DISCLAIM and NOTICE files exist;
> >> - Release candidate tar is signed correctly, by "yang...@apache.org”;
> >> - Shasum of the tar is correct;
> >> - “incubating” exists in tar file name and documentation;
> >> - License headers exist in files if necessary.
> >>
> >> However, I found
> >>
> >> - the following files from 3rd-party are not listed in LICENSE.txt:
> >> 1. be/src/olap/rowset/alpha_rowset_writer.h
> >> 2. be/src/olap/rowset/segment_v2/empty_segment_iterator.cpp
> >>
> >> - the following files are listed (IMO) but with wrong file path:
> >> 1. Should be
> >> "fe/fe-common/src/main/java/org/apache/doris/common/jmockit”, but was
> >> listed as "fe/fe-common/src/test/java/org/apache/doris/common/jmockit”
> in
> >> LICENSE.txt
> >>
> >> The missing 3rd-party files in LICENSE.txt is not a blocker IMO because
> >> there are files from the same owner ("be/src/olap/lru_cache.h”,
> >> “be/src/olap/lru_cache.cpp”, "be/src/olap/skiplist.h”) which are listed.
> >>
> >> And the wrong file path is easily fixed in mind so I think you can
> proceed
> >> but remember to fix in the next release.
> >>
> >>
> >>> On Apr 7, 2021, at 13:36, 寒江雪 <yangz...@gmail.com> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> Please review and vote on Apache Doris 0.14.0-incubating-rc04 release.
> >>>
> >>> Apache Doris is an MPP-based interactive SQL data warehousing for
> >> reporting
> >>> and analysis.
> >>>
> >>> The Apache Doris community has voted on and approved this release:
> >>>
> >>
> https://lists.apache.org/thread.html/rc95a58e64b926dc89b61e747fd11f8cb7bb173d95395fa26d02d2c00%40%3Cdev.doris.apache.org%3E
> >>>
> >>> The vote result email thread:
> >>>
> >>
> https://lists.apache.org/thread.html/r14fc4ffeb31046343570a226dd7870ca74b0f15fbad492b09f0bb69f%40%3Cdev.doris.apache.org%3E
> >>>
> >>> The release candidate has been tagged in GitHub as 0.14.0-rc04,
> available
> >>> here:
> >>> https://github.com/apache/incubator-doris/releases/tag/0.14.0-rc04
> >>>
> >>> Thanks to everyone who has contributed to this release, and there is a
> >>> simple release notes can be found here:
> >>> https://github.com/apache/incubator-doris/issues/5374
> >>>
> >>> The artifacts (source, signature and checksum) corresponding to this
> >> release
> >>> candidate can be found here:
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.14/0.14.0-rc04/
> >>>
> >>> This has been signed with PGP key 59F2ACED, corresponding to
> >>> yang...@apache.org.
> >>> KEYS file is available here:
> >>> https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
> >>> It is also listed here:
> >>> https://people.apache.org/keys/committer/yangzhg.asc
> >>>
> >>> The vote will be open for at least 72 hours.
> >>> [ ] +1 Approve the release
> >>> [ ] +0 No opinion
> >>> [ ] -1 Do not release this package because ...
> >>>
> >>> To verify and build, you can refer to the following wiki:
> >>>
> >>
> https://github.com/apache/incubator-doris/wiki/How-to-verify-Apache-Release
> >>> https://wiki.apache.org/incubator/Incubator+Release+Checklist
> >>>
> >>> You can also refer to instruction:
> >>>
> >>> Firstly, you must install and start docker service, and then you could
> >>> build Doris as the following steps:
> >>>
> >>> Step1: Pull the docker image with Doris building environment
> >>> $ docker pull apachedoris/doris-dev:build-env-1.2
> >>> You can check it by listing images, its IMAGE ID is d854b488afaf
> >>>
> >>> Step2: Run the Docker image
> >>> You can run the image directly:
> >>> $ docker run -it apachedoris/doris-dev:build-env1.2
> >>>
> >>> Step3: Download Doris source
> >>> Now you should in the docker environment, and you can download the
> Doris
> >>> source package.
> >>> (If you have downloaded the source and it is not in image, you can map
> >> its
> >>> path to image in Step2.)
> >>> $ wget
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.14/0.14.0-rc04/apache-doris-0.14.0-incubating-src.tar.gz
> >>>
> >>> Step4: Build Doris
> >>> Now you can decompress and enter Doris source path and build Doris.
> >>> $ tar -zxvf apache-doris-0.14.0-incubating-src.tar.gz
> >>> $ cd apache-doris-0.14.0-incubating-src
> >>> $ sh build.sh
> >>>
> >>> Best Regards,
> >>> Yang Zhengguo
> >>
> >>
> >>
> >> —————————
> >> Zhenxu Ke (柯振旭)
> >> GitHub @kezhenxu94
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail: general-h...@incubator.apache.org
> >>
> >>
>
> —————————
> Zhenxu Ke (柯振旭)
> GitHub @kezhenxu94
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
